Selection flash is improperly scaled by frame rate

[Stubbjax]

Prerequisites

• I have searched for similar issues and confirmed this is not a duplicate

Game Version

• Command & Conquer Generals
• Command & Conquer Generals: Zero Hour
• Other (please specify below)

Bug Description

When selecting units or buildings, the selection flash is improperly scaled by the frame rate in network games. The selection flash will not update at all when the frame rate is set to 30.

Reproduction Steps

1. Start a new game via Multiplayer → Network
2. Use CTRL + NUMPAD PLUS or CTRL + NUMPAD MINUS to change the target frame rate
3. Select buildings / units

Additional Context

SELECTION_FLASH.mp4

[xezon]

The flash is only gone at 30 when switching to 30 while having an object selected.

[Stubbjax]

The flash is only gone at 30 when switching to 30 while having an object selected.

Selecting 10 objects at 30 fps and then changing it to above 30 fps will then play the flash on all 10 objects. So it seems the update is just frozen.

[xezon]

It is yes, via Network::isStalling