There is a significant amount of code hidden behind compile-time guards such as !RETAIL_COMPATIBLE_CRC and other similar compatibility-related guards
This code is intended to be used in the future once retail compatibility is dropped and may already be used in GeneralsOnline builds. However, since our current CI pipeline only builds retail-compatible configurations, this guarded code is not regularly compiled or validated.
In PR #2318, a fix had to be applied because non-retail-compatible code was not compiling. This indicates that we currently have no automated safety net to prevent regressions in these configurations.
Proposed solution
Create a Win32 Build with the following guard settings
- RETAIL_COMPATIBLE_CRC = 0
- PRESERVE_RETAIL_BUG = 0
- .....
There is a significant amount of code hidden behind compile-time guards such as !RETAIL_COMPATIBLE_CRC and other similar compatibility-related guards
This code is intended to be used in the future once retail compatibility is dropped and may already be used in GeneralsOnline builds. However, since our current CI pipeline only builds retail-compatible configurations, this guarded code is not regularly compiled or validated.
In PR #2318, a fix had to be applied because non-retail-compatible code was not compiling. This indicates that we currently have no automated safety net to prevent regressions in these configurations.
Proposed solution
Create a Win32 Build with the following guard settings