Rapidly double clicking menu buttons can open the same screen twice and lead to shell state corruption and crashes

[MrS-ibra]

Prerequisites

• I have searched for similar issues and confirmed this is not a duplicate

Game Version

• Command & Conquer Generals
• Command & Conquer Generals: Zero Hour
• Other (please specify below)

Bug Description

If a menu button that opens a screen via Shell::push is pressed twice rapidly, the same screen can open as two separate instances, and advancing with one will leave the other drawn on top of whatever comes next and lead to undefined behavior when interacting with it
This bug is retail. However will become more common and be brought to the surface following #2056 and #2840

This issue is confirmed to happen on these screens:
Replay Browser menu
Saved Games menu
Network screen

Reproduction Steps

1. Use a build following feat(gui): Implement user option to scale the game window transition speed #2840 and set GameWindowTransitionSpeedMultiplier at 2.5 for easiest reproduction
2. Rapidly click the Replays or Saved Games buttons

Additional Context

Shell.menu.mp4

[xezon]

I have seen this before. I wonder if we already have a bug report for it.

[MrS-ibra]

I searched in the Code and Patch repositories and this issue didnt seem to be tracked.

[Caball009]

I cannot reproduce this with the latest main branch VS22 debug build.

Are you using different window files? Also, can you test with windowed mode and / or quickstart?

[MrS-ibra]

Are you using different window files? Also, can you test with windowed mode and / or quickstart?

I did test using custom window files and original, windowed and fullscreen, with and without quickstart, I can reproduce it most of the time with GameWindowTransitionSpeedMultiplier set at 2.5 in options.ini. You will have harder time reproducing it with the default value, hence why I mentioned this will be brought to the surface following recent GUI transition decoupling changes and with players encouraged to increase the speed of of Window transitions. (and players being used to double clicking everything in this game :p).

Try GameWindowTransitionSpeedMultiplier = 2.5 and rapidly clicking Load Replays or Load Games buttons. The screen will show a flicker indicating it did reproduce.