AsciiString::format_va is unsafe

[xezon]

void AsciiString::format_va(const AsciiString& format, va_list args)
{
	validate();
	char buf[MAX_FORMAT_BUF_LEN];
  if (_vsnprintf(buf, sizeof(buf)/sizeof(char)-1, format.str(), args) < 0)
			throw ERROR_OUT_OF_MEMORY;
	set(buf);
	validate();
}

https://learn.microsoft.com/en-us/cpp/c-runtime-library/reference/vsnprintf-vsnprintf-vsnprintf-l-vsnwprintf-vsnwprintf-l?view=msvc-170

vsnprintf function always writes a null terminator, even if it truncates the output. When you use _vsnprintf and _vsnwprintf, the buffer is null-terminated only if there's room at the end (that is, if the number of characters to write is less than count)

We either need to use vsnprintf with len(buf) or zero terminate buf with _vsnprintf with len(buf)-1

[xezon]

I started working on this. Plan is to replace the Microsoft specific _vsnprintf and associates with standard calls. It affects a number of files in the code base.

[xezon]

Also note to myself: There are a few more throw ERROR_OUT_OF_MEMORY that can be demoted to assert.