Disabling a Power Plant scaffold with a MicroWave gives you negative power, killing the scaffold will make it permanent

[DrGoldFish1]

A Power Plant can give you +5, +8 or +10 power when its completed, a Power Plant scaffold will give no power advantages.

There is a bug were if you disable a PowerPlant scaffold with a microwave tank it will give you a negative power. So you will get -5, -8 or -10 power from the disabling. If you then kill the already disabled scaffold the the negative power will be permanently applied. meaning you will need an additional powerplant for the remaining of the game.

The more powerplants scaffolds you lose in this way the more power you will lose.

[xezon]

In Patch there currently is a workaround implemented for this bug.

If we fix this in code, then we can revert the workaround.

• Fix: USA and China Microwave Tank negative power bug GeneralsGamePatch#7

[Caball009]

In Patch there currently is a workaround implemented for this bug.

If we fix this in code, then we can revert the workaround.

TheSuperHackers/GeneralsGamePatch#7

This one looks really easy to fix.

GeneralsGameCode/GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Object.cpp

Lines 3841 to 3848 in a86ed98

	// We will need to adjust power ... somehow ...
	Int powerToAdjust = getTemplate()->getEnergyProduction();
	if( powerToAdjust > 0 )
	{
	// We can't affect something that consumes, or else we go low power which removes the consumption
	// which makes us not low power so we add the consumption so we go low power...
	// This check also guaards the IsDisabled in friend_adjustPower above

This can go either inside or before the if statement. This prevents the power level from decreasing / increasing as long as the power plant is still under construction.

#if !RETAIL_COMPATIBLE_CRC
	if (testStatus(OBJECT_STATUS_UNDER_CONSTRUCTION))
		return;
#endif

I might create a PR later, but considering that the code breaks compatibility it's not high priority.