[GEN][ZH] Disable the Firewall Port Override and HTTP Proxy settings from the Options Menu when in-game#1029
Merged
xezon merged 2 commits intoJun 12, 2025
Conversation
Mauller
approved these changes
Jun 9, 2025
Mauller
left a comment
Mauller
left a comment
There was a problem hiding this comment.
Looks good and works as intended.
Already tested as part of the other options menu disabled settings fix.
…the Options Menu when in game
xezon
force-pushed
the
xezon/fix-optionsmenu-portoverride-httpproxy-disabled
branch
from
3530eaa to
2cffe14
Compare
Author
|
Replicated in Generals without conflicts. |
|
Copy across looks clean |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…from the Options Menu when in-game (TheSuperHackers#1029)
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Feb 23, 2026
…from the Options Menu when in-game (TheSuperHackers#1029)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change disables the Firewall Port Override and HTTP Proxy settings from the Options Menu when in game. There is no use in being able to change these at this moment. All other Network settings are already disabled.
I did not check if changing these values in-game would cause any issues. Probably not.
All Network options disabled in-game
TODO