Skip to content

[ZH] Refactor logical expression in AcademyStats::init() #1047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 1 commit into from
Jun 11, 2025
Merged

[ZH] Refactor logical expression in AcademyStats::init() #1047

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions GeneralsMD/Code/GameEngine/Source/Common/RTS/AcademyStats.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,9 @@ void AcademyStats::init( const Player *player )
const PlayerTemplate *plyrTemplate = player->getPlayerTemplate();

if( !plyrTemplate ||
plyrTemplate->getBaseSide().compareNoCase( "USA" ) &&
( plyrTemplate->getBaseSide().compareNoCase( "USA" ) &&
plyrTemplate->getBaseSide().compareNoCase( "China" ) &&
plyrTemplate->getBaseSide().compareNoCase( "GLA" ) )
plyrTemplate->getBaseSide().compareNoCase( "GLA" ) ) )
{
//Admittedly, this is a massive violation of data driven design. Shame on me!
//Unknown side... don't provide ANY advice. Simplicity reasons.
Expand Down
Loading