Skip to content

[ZH] Set correct fake CRC for Zero Hour CD 1.04 #1051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 1 commit into from
Jun 15, 2025
Merged

[ZH] Set correct fake CRC for Zero Hour CD 1.04 #1051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Generals/Code/GameEngine/Source/Common/GlobalData.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -992,9 +992,9 @@ GlobalData::GlobalData()
// Simulate the EXE's CRC value to force Network and Replay compatibility with another build.
#if (defined(_MSC_VER) && _MSC_VER < 1300) && RETAIL_COMPATIBLE_CRC

@helmutbuhler helmutbuhler Jun 15, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add more conditions here?
&& !defined(RTS_DEBUG) && !defined(RTS_INTERNAL) && !defined(_DEBUG)
If any of those defines are set the build won't be compatible.

@xezon xezon Jun 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_DEBUG I can see.

Is the RTS_DEBUG/RTS_INTERNAL incompatibility permanent? I was under the impression that it is just temporary. Anyway, I think we can do that in another follow up change then.

@helmutbuhler helmutbuhler Jun 15, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTS_DEBUG/RTS_INTERNAL add so much code, I'd be shocked if it doesn't add incompatibilities. The PR that I made and is waiting for approval only made release mode compatible when debug_logging and/or debug_crashing is enabled.


#define GENERALS_108_CD_EXE_CRC 0x93d1eab4
#define GENERALS_108_STEAM_EXE_CRC 0x8d6e4dd7
#define GENERALS_108_EAAPP_EXE_CRC 0xb07fbd50
#define GENERALS_108_CD_EXE_CRC 0x93d1eab4u
#define GENERALS_108_STEAM_EXE_CRC 0x8d6e4dd7u
#define GENERALS_108_EAAPP_EXE_CRC 0xb07fbd50u

exeCRC.set(GENERALS_108_CD_EXE_CRC);
DEBUG_LOG(("Fake EXE CRC is 0x%8.8X\n", exeCRC.get()));
Expand Down
6 changes: 3 additions & 3 deletions GeneralsMD/Code/GameEngine/Source/Common/GlobalData.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,9 +1001,9 @@ GlobalData::GlobalData()
// Simulate the EXE's CRC value to force Network and Replay compatibility with another build.
#if (defined(_MSC_VER) && _MSC_VER < 1300) && RETAIL_COMPATIBLE_CRC

#define GENERALSMD_104_CD_EXE_CRC 0x4f6c5afe
#define GENERALSMD_104_STEAM_EXE_CRC 0xcb430f5f
#define GENERALSMD_104_EAAPP_EXE_CRC 0x488d90f9
#define GENERALSMD_104_CD_EXE_CRC 0x3b6fb2cfu
#define GENERALSMD_104_STEAM_EXE_CRC 0xf6a4221bu
#define GENERALSMD_104_EAAPP_EXE_CRC 0xc4181eb9u

exeCRC.set(GENERALSMD_104_CD_EXE_CRC);
DEBUG_LOG(("Fake EXE CRC is 0x%8.8X\n", exeCRC.get()));
Expand Down
Loading