fix(draw): Fix wheel rotation math#1507
Merged
Merged
Conversation
xezon
force-pushed
the
xezon/fix-wheels-spin-math
branch
from
f0c34ac to
d4fe0b9
Compare
Author
|
Replicated in Generals without conflicts. Tested in Generals and looked ok. Wheels are spinning and power sliding works. |
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change just fixes the wheel rotation math. Is unlikely to be user facing but could be if a unit would drive forward for very long distances. Essentially the wheel rotation will keep accumulating and if the float number grows larger enough, then the float imprecision eventually would make the wheels no longer spin.
TODO