Skip to content

feat(options): Implement user options for Screen Edge Scrolling#1538

Merged
xezon merged 5 commits into
TheSuperHackers:mainfrom
xezon:xezon/impl-edgescroll-user-options
Sep 10, 2025
Merged

feat(options): Implement user options for Screen Edge Scrolling#1538
xezon merged 5 commits into
TheSuperHackers:mainfrom
xezon:xezon/impl-edgescroll-user-options

Conversation

@xezon

@xezon xezon commented Sep 4, 2025

Copy link
Copy Markdown

This change implements user options to control the screen edge scrolling behavior.

The Options.ini gets 2 new settings with defaults that match the original behavior:

ScreenEdgeScrollEnabledInWindowedApp = no
ScreenEdgeScrollEnabledInFullscreenApp = yes

TODO

  • Replicate to Generals

@xezon xezon added this to the Important features milestone Sep 4, 2025
@xezon xezon added Enhancement Is new feature or request Major Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour labels Sep 4, 2025
@xezon

xezon commented Sep 5, 2025

Copy link
Copy Markdown
Author

I think better options would be:

ScreenEdgeScrollEnabledInWindowedApp = no
ScreenEdgeScrollEnabledInFullscreenApp = yes

This would make them exclusive and not dependent on each other.

Edit: Updated.

@xezon xezon changed the title feat(options): Implement user options to control the screen edge scrolling behavior feat(options): Implement user options for Screen Edge Scrolling Sep 5, 2025
@xezon xezon force-pushed the xezon/impl-edgescroll-user-options branch from 1a227e3 to 0a28e8c Compare September 5, 2025 12:31

@Mauller Mauller Sep 9, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to cast this to bool otherwise the compilers going to complain.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right it causes warning. Fixed.

@Mauller Mauller left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xezon xezon force-pushed the xezon/impl-edgescroll-user-options branch from 0a28e8c to 5a8dc95 Compare September 10, 2025 10:17
@xezon

xezon commented Sep 10, 2025

Copy link
Copy Markdown
Author

Replicated to Generals with mini conflict.

Improved code comments a bit.

@xezon xezon merged commit 36b5277 into TheSuperHackers:main Sep 10, 2025
18 checks passed
@xezon xezon deleted the xezon/impl-edgescroll-user-options branch September 10, 2025 10:30
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
…uperHackers#1538)

Adds new options ScreenEdgeScrollEnabledInWindowedApp=no, ScreenEdgeScrollEnabledInFullscreenApp=yes to Options.ini
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Feb 23, 2026
…uperHackers#1538)

Adds new options ScreenEdgeScrollEnabledInWindowedApp=no, ScreenEdgeScrollEnabledInFullscreenApp=yes to Options.ini
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement Is new feature or request Gen Relates to Generals Major Severity: Minor < Major < Critical < Blocker ZH Relates to Zero Hour

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Revisit edge scrolling in windowed mode

2 participants