fix(guiedit): Fix crash on GuiEdit launch by initializing GlobalLanguage after GlobalData#1576
Merged
Merged
Conversation
…tialization dependency
Mauller
added
Major
Mauller
changed the title
Mauller
changed the title
xezon
approved these changes
Sep 14, 2025
xezon
changed the title
xezon
changed the title
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…age after GlobalData (TheSuperHackers#1576)
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Feb 23, 2026
…age after GlobalData (TheSuperHackers#1576)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a startup crash within GuiEdit that was introduced by changed in Global Languge in PR #1457
This crash occured due to the global language object being initialised before global data in GuiEdit.
Global language is now dependent on being initialised after Global Data. This is due to the recent need for the user data directory string when retrieving options.ini settings within global language.
The user data directory string is initialised when the global data is initialised, resulting in a null string being handled within global languages, resulting in the crash.
For some reason the VS22 builds were immune to the issue. But the VC6 builds would always crash.