bugfix(fps): Fix mouse wheel zoom speed and decouple zoom update from logic step#1587
Merged
Merged
Conversation
xezon
added
Bug
2 tasks
|
The zoom change is more instant at higher FPS. 8mb.video-oxY-PWatJMcD.mp4 |
xezon
force-pushed
the
xezon/fix-mouse-wheel-zoom
branch
from
1f75884 to
83d5f14
Compare
xezon
changed the title
xezon
added
Gen
Author
Fixed. |
xezon
commented
Sep 18, 2025
|
Mouse wheel zoom works normally during gameplay, but it's still noticeably slow in replay mode. |
Author
Indeed. After investigation I found fix #1597 also fixes the Replay zoom speed. So that problem is covered with the other change. |
xezon
force-pushed
the
xezon/fix-mouse-wheel-zoom
branch
from
83d5f14 to
1802f65
Compare
Author
|
Replicated in Generals without conflicts |
xezon
changed the title
1 task
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes the mouse wheel zoom speed.
This bug was introduced by #1451
TODO