Skip to content

refactor: Replace custom strrchr implementations with standard function#1782

Merged
xezon merged 4 commits into
TheSuperHackers:mainfrom
bobtista:bobtista/refactor-strrchr
Nov 3, 2025
Merged

refactor: Replace custom strrchr implementations with standard function#1782
xezon merged 4 commits into
TheSuperHackers:mainfrom
bobtista:bobtista/refactor-strrchr

Conversation

@bobtista

@bobtista bobtista commented Nov 2, 2025

Copy link
Copy Markdown

@xezon xezon added Minor Severity: Minor < Major < Critical < Blocker Refactor Edits the code with insignificant behavior changes, is never user facing labels Nov 2, 2025
@xezon

xezon commented Nov 2, 2025

Copy link
Copy Markdown

When searching code base for *pEnd == '\\' there are more hits. Please treat all of them.

@xezon xezon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct.

Comment thread Core/GameEngine/Source/Common/System/Debug.cpp Outdated
@xezon xezon changed the title refactor: Replace manual strrchr implementation with standard function refactor: Replace custom strrchr implementations with standard function Nov 3, 2025
@xezon xezon merged commit 10f130a into TheSuperHackers:main Nov 3, 2025
17 checks passed
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Minor Severity: Minor < Major < Critical < Blocker Refactor Edits the code with insignificant behavior changes, is never user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Poor man's strrchr

2 participants