Skip to content

refactor: Remove superfluous string buffer copies#1800

Merged
xezon merged 1 commit into
TheSuperHackers:mainfrom
Skyaero42:skyaero/remove-unnecessary-strcpy
Nov 6, 2025
Merged

refactor: Remove superfluous string buffer copies#1800
xezon merged 1 commit into
TheSuperHackers:mainfrom
Skyaero42:skyaero/remove-unnecessary-strcpy

Conversation

@Skyaero42

Copy link
Copy Markdown

@Skyaero42 Skyaero42 self-assigned this Nov 5, 2025
@Skyaero42 Skyaero42 added Refactor Edits the code with insignificant behavior changes, is never user facing Stability Concerns stability of the runtime labels Nov 5, 2025
@Skyaero42 Skyaero42 force-pushed the skyaero/remove-unnecessary-strcpy branch from cb7f7dc to 6d6c840 Compare November 5, 2025 21:02

@xezon xezon left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good to me.

@xezon xezon changed the title refactor: remove redundant use of strlcpy refactor: Remove superfluous string buffer copies Nov 6, 2025
@xezon xezon removed the Stability Concerns stability of the runtime label Nov 6, 2025
@xezon xezon merged commit f8d2336 into TheSuperHackers:main Nov 6, 2025
18 checks passed
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
@Skyaero42 Skyaero42 deleted the skyaero/remove-unnecessary-strcpy branch January 23, 2026 12:41
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Refactor Edits the code with insignificant behavior changes, is never user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants