Skip to content

fix(display): Fix VideoBuffer format selection in W3DDisplay::createVideoBuffer() #2265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 1 commit into from
Feb 8, 2026
Merged

fix(display): Fix VideoBuffer format selection in W3DDisplay::createVideoBuffer() #2265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DDisplay.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2688,8 +2688,8 @@ VideoBuffer* W3DDisplay::createVideoBuffer( void )
return nullptr;
}
}
// on low mem machines, render every video in 16bit except for the EA Logo movie
if(!TheGlobalData->m_playIntro )//&& TheGameLODManager && (!TheGameLODManager->didMemPass() || W3DShaderManager::getChipset() == DC_GEFORCE2))
// on low mem machines, render every video in 16bit
if (TheGameLODManager && (!TheGameLODManager->didMemPass() || W3DShaderManager::getChipset() == DC_GEFORCE2))
format = VideoBuffer::TYPE_R5G6B5;
Comment thread
xezon marked this conversation as resolved.

W3DVideoBuffer *buffer = NEW W3DVideoBuffer( format );
Expand Down
4 changes: 2 additions & 2 deletions GeneralsMD/Code/GameEngineDevice/Source/W3DDevice/GameClient/W3DDisplay.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2797,8 +2797,8 @@ VideoBuffer* W3DDisplay::createVideoBuffer( void )
return nullptr;
}
}
// on low mem machines, render every video in 16bit except for the EA Logo movie
if(!TheGlobalData->m_playIntro )//&& TheGameLODManager && (!TheGameLODManager->didMemPass() || W3DShaderManager::getChipset() == DC_GEFORCE2))
// on low mem machines, render every video in 16bit
if (TheGameLODManager && (!TheGameLODManager->didMemPass() || W3DShaderManager::getChipset() == DC_GEFORCE2))
format = VideoBuffer::TYPE_R5G6B5;
Comment thread
xezon marked this conversation as resolved.

W3DVideoBuffer *buffer = NEW W3DVideoBuffer( format );
Expand Down
Loading