Skip to content

fix(netpacket): Fix incorrect improbable return value in NetPacket::GetBufferSizeNeededForCommand() #2328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 1 commit into from
Feb 21, 2026
Merged

fix(netpacket): Fix incorrect improbable return value in NetPacket::GetBufferSizeNeededForCommand() #2328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Core/GameEngine/Source/GameNetwork/NetPacket.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ UnsignedInt NetPacket::GetBufferSizeNeededForCommand(NetCommandMsg *msg) {
// This is where the fun begins...

if (msg == nullptr) {
return TRUE; // There was nothing to add, so it was successful.
return 0; // There was nothing to add.
}
// Use the virtual function for all command message types
return msg->getPackedByteCount();
Expand Down
Loading