refactor(view): Simplify code to set location for Replay Camera

[xezon]

This change simplifies the code to set the location for the Replay Camera.

Note that the Replay Camera currently does not work, which will be fixed soon.

To test the Replay Camera, the following line needs to be commented:

TheTacticalView->lockViewUntilFrame( getFrame() + 1 );

TODO

• Replicate in Generals

[greptile-apps]

Greptile Summary

This PR simplifies the replay camera location-setting code by replacing the intermediate ViewLocation object and its init/setLocation round-trip with direct calls to setPosition, setAngle, setPitch, and setZoom on TheTacticalView. The change is applied to both the Generals and GeneralsMD variants of GameLogicDispatch.cpp.

In View.h, setPosition is promoted from protected to public (necessary for the new call sites), getPosition(Coord3D*) drops its virtual keyword (no subclass overrides it), whitespace is cleaned up, and the ViewLocation constructor initializers are corrected from 0.0 (double) to 0.0f (float) to match the Real (float) type.

• The behavioral difference from bypassing View::setLocation (which calls forceRedraw()) has already been discussed and confirmed acceptable by a senior developer in a prior thread.
• No subclass overrides getPosition(Coord3D*) or setPosition, so removing virtual and changing visibility is safe.
• Local variables are now const-qualified, improving clarity.

Confidence Score: 4/5

• This PR is safe to merge — it's a straightforward refactor with no functional risk beyond the already-discussed forceRedraw() omission.
• Score of 4 reflects a clean, well-scoped refactor. The only behavioral change (skipping forceRedraw) has been acknowledged and confirmed acceptable. No subclass overrides are broken by the virtual/visibility changes. The replay camera feature is noted as not yet working, so the risk surface is minimal. Deducted one point because the feature is not yet testable end-to-end.
• No files require special attention.

Important Files Changed

Filename	Overview
Core/GameEngine/Include/GameClient/View.h	Moves setPosition from protected to public, removes virtual from getPosition(Coord3D*), cleans up whitespace, and initializes ViewLocation members with 0.0f instead of 0.0.
Generals/Code/GameEngine/Source/GameLogic/System/GameLogicDispatch.cpp	Replaces ViewLocation intermediate object with direct calls to setPosition, setAngle, setPitch, setZoom on the tactical view. Adds const qualifiers to local variables.
GeneralsMD/Code/GameEngine/Source/GameLogic/System/GameLogicDispatch.cpp	Same simplification as the Generals variant — replaces ViewLocation with direct camera property setters. Identical change pattern.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[MSG_SET_REPLAY_CAMERA received] --> B{isPlaybackMode &\nuseCameraInReplay &\nobserverMatch?}
    B -- No --> Z[Skip]
    B -- Yes --> C{isCameraMovementFinished?}
    C -- No --> Z
    C -- Yes --> D[Extract pos, angle, pitch, zoom from message]

    subgraph Before[Before - Using ViewLocation]
        D1[Create ViewLocation] --> D2["loc.init(pos, angle, pitch, zoom)"]
        D2 --> D3["setLocation(&loc)"]
        D3 --> D4["Internally calls setPosition, setAngle, setPitch, setZoom, forceRedraw"]
    end

    subgraph After[After - Direct Calls]
        E1["setPosition(&pos)"] --> E2["setAngle(angle)"]
        E2 --> E3["setPitch(pitch)"]
        E3 --> E4["setZoom(zoom)"]
    end

    D --> After
    E4 --> F["lockViewUntilFrame(frame + 1)"]

Loading

_{Last reviewed commit: 64f8d56}

[greptile-apps]

_{2 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[Mauller]

looks okay

[xezon]

Replicated in Generals without conflicts.