chore(pathfinder): Cleanup formatting and fix an incomplete optimization in PathfindZoneManager:calculateZones()

[Mauller]

merge by rebase

This PR is split out from the AiPathfind unification PR to reduce the difference in the merge between Generals and Zero Hours AiPathfind.cpp files.

It also contains a fix for an optimization that was missed in the zero hour code, this fix does not cause any mismatching and is why this PR should be merged by rebase.

There was extensive changes made to PathfindZoneManager:calculateZones() which introduced a large number of formatting differences relative to the rest of the code.

This PR more closely aligns Zero Hours PathfindZoneManager:calculateZones() with Generals implementation by doing the following:

• Fixes leading spaces by changing them for leading tabs
• Changes while loops back to for loops to match the original implementaitons in generals ( makes the code much cleaner too )
• Fixes style of open braces to match the rest of the code by placing them inline with their conditional/logical statement ( K&R style )
• Reverts a few small refactors in the zero hour code to their Generals implementation since they were cleaner in style

[Mauller]

Note - This change is how it was implemented in generals, it makes comparissons in winmerge easier and is far cleaner than the refactor zero hour introduced

[Mauller]

Note - This change is how it was implemented in generals, minus the comment being removed. I left the zero hour comment above the for loop instead to keep the code block clearer.

[greptile-apps]

Greptile Summary

Cleaned up formatting in PathfindZoneManager::calculateZones() by converting spaces to tabs, changing while loops to for loops, and standardizing brace placement to K&R style. Also fixed an incomplete optimization where the top cell comparison (j > globalBounds.lo.y) was missing the notTerrainOrCrusher conditional guard that the left cell comparison already had, making both branches now consistent.

• Converted 4 while loops to for loops for better readability
• Standardized indentation from spaces to tabs
• Moved opening braces inline with conditions (K&R style)
• Removed obsolete REGISTER keyword
• Fixed logic bug where water/ground/cliff zone checks for top cell weren't properly guarded by notTerrainOrCrusher flag
• Added clarifying comment for zone initialization loop

Confidence Score: 5/5

• This PR is safe to merge with no risk
• The changes are entirely formatting improvements and a single logic fix that makes the code more consistent. The logic fix adds a missing conditional guard that was already present in an equivalent code path, reducing the chance of incorrect zone calculations. All custom style rules are followed, and the changes align the Zero Hour implementation more closely with the Generals version.
• No files require special attention

Important Files Changed

Filename	Overview
GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp	Formatting cleanup (tabs, for loops, K&R braces) and logic fix to add missing notTerrainOrCrusher check for top cell comparisons

_{Last reviewed commit: 2b8e7fd}

[Mauller]

Note - This change is why the PR wants to be merged by rebase. It will make the dif cleaner in the unification PR as well.

This is a small optimisation overall and wants to be seperate in case we needed to revert it.

[Mauller]

Note - This was removed to make the code more in line with the generals implementation. Helping make the Diff clearer in the unification.

The register keyword is also deprecated in c++17 and beyond and using the class variable is of no issue. There should be little to no performance difference.

[Skyaero42]

This looks good to me