Skip to content

bugfix(logic): Restore retail compatibility after change to frozen time check #2803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Caball009 wants to merge 2 commits into
base: main
Choose a base branch
from
+28 −26
Open

bugfix(logic): Restore retail compatibility after change to frozen time check #2803

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bee22c3
bugfix(logic): Check if time is frozen directly after script engine u…
Caball009 Jul 4, 2026
cc04254
Replicated in Generals.
Caball009 Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 8 additions & 13 deletions Generals/Code/GameEngine/Source/Common/GameEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -654,7 +654,7 @@ void GameEngine::resetSubsystems()
/// -----------------------------------------------------------------------------------------------
Bool GameEngine::canUpdateGameLogic(UnsignedInt logicTimeQueryFlags)
{
// Must be first.
// This updates the paused game status of the game logic.
TheGameLogic->preUpdate();

TheFramePacer->setTimeFrozen(isTimeFrozen());
Expand Down Expand Up @@ -748,20 +748,15 @@ void GameEngine::update()
}
}

const Bool canUpdate = canUpdateGameLogic(FramePacer::IgnoreFrozenTime | FramePacer::IgnoreHaltedGame);
const Bool canUpdateLogic = canUpdate && !TheFramePacer->isGameHalted() && !TheFramePacer->isTimeFrozen();
const Bool canUpdateScript = canUpdate && !TheFramePacer->isGameHalted();

if (canUpdateLogic)
// TheSuperHackers @info Ignores frozen time because the script engine needs updating in the logic update regardless.
if (canUpdateGameLogic(FramePacer::IgnoreFrozenTime))
{
TheGameClient->step();
TheGameLogic->UPDATE();
}
else if (canUpdateScript)
{
// TheSuperHackers @info Still update the Script Engine to allow
// for scripted camera movements while the time is frozen.
TheScriptEngine->UPDATE();

if (!TheFramePacer->isTimeFrozen())
{
TheGameClient->step();
}
}
}
}
Expand Down
6 changes: 6 additions & 0 deletions Generals/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3193,6 +3193,12 @@ void GameLogic::update()
TheScriptEngine->UPDATE();
}

// TheSuperHackers @info Updates the frozen time status because it may have changed after the script engine update.
TheFramePacer->setTimeFrozen(TheGameEngine->isTimeFrozen());

if (TheFramePacer->isTimeFrozen())
return;

// Note - TerrainLogic update needs to happen after ScriptEngine update, but before object updates. jba.
// This way changes in bridges are noted in the script engine before being cleared in TerrainLogic->update
{
Expand Down
21 changes: 8 additions & 13 deletions GeneralsMD/Code/GameEngine/Source/Common/GameEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -821,7 +821,7 @@ void GameEngine::resetSubsystems()
/// -----------------------------------------------------------------------------------------------
Bool GameEngine::canUpdateGameLogic(UnsignedInt logicTimeQueryFlags)
{
// Must be first.
// This updates the paused game status of the game logic.
TheGameLogic->preUpdate();

TheFramePacer->setTimeFrozen(isTimeFrozen());
Expand Down Expand Up @@ -915,20 +915,15 @@ void GameEngine::update()
}
}

const Bool canUpdate = canUpdateGameLogic(FramePacer::IgnoreFrozenTime | FramePacer::IgnoreHaltedGame);
const Bool canUpdateLogic = canUpdate && !TheFramePacer->isGameHalted() && !TheFramePacer->isTimeFrozen();
const Bool canUpdateScript = canUpdate && !TheFramePacer->isGameHalted();

if (canUpdateLogic)
// TheSuperHackers @info Ignores frozen time because the script engine needs updating in the logic update regardless.
if (canUpdateGameLogic(FramePacer::IgnoreFrozenTime))
{
TheGameClient->step();
TheGameLogic->UPDATE();
}
else if (canUpdateScript)
{
// TheSuperHackers @info Still update the Script Engine to allow
// for scripted camera movements while the time is frozen.
TheScriptEngine->UPDATE();

if (!TheFramePacer->isTimeFrozen())
{
TheGameClient->step();
}
}
}
}
Expand Down
6 changes: 6 additions & 0 deletions GeneralsMD/Code/GameEngine/Source/GameLogic/System/GameLogic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3732,6 +3732,12 @@ void GameLogic::update()
TheScriptEngine->UPDATE();
}

// TheSuperHackers @info Updates the frozen time status because it may have changed after the script engine update.
TheFramePacer->setTimeFrozen(TheGameEngine->isTimeFrozen());

if (TheFramePacer->isTimeFrozen())
return;

// Note - TerrainLogic update needs to happen after ScriptEngine update, but before object updates. jba.
// This way changes in bridges are noted in the script engine before being cleared in TerrainLogic->update
{
Expand Down
Loading