chore(sortingrenderer): Remove unused function Insert_VolumeParticle

[stephanmeesters]

This PR removes the unused function Insert_VolumeParticle in SortingRendererClass.

Volume particles use the Insert_Triangles function:

GeneralsGameCode/Core/Libraries/Source/WWVegas/WW3D2/pointgr.cpp

Lines 1898 to 1901 in 984db42

	if ( sort )
	SortingRendererClass::Insert_Triangles (0, delta / verticesperprimitive, 0, delta);
	else
	DX8Wrapper::Draw_Triangles (0, delta / verticesperprimitive, 0, delta);

General info about volume particles

Volume particles are particles rendered as multiple spaced slices to create a fake volume effect:

[greptile-apps]

Greptile Summary

This PR removes the unused static method Insert_VolumeParticle from SortingRendererClass, cleaning up dead code confirmed to have no callers in the codebase.

• sortingrenderer.h: Declaration of Insert_VolumeParticle removed from the public API.
• sortingrenderer.cpp: Full implementation removed; pointgr.cpp (the volume particle rendering path) already routes through Insert_Triangles, making this function genuinely unreachable.

Confidence Score: 5/5

Safe to merge — only dead code is removed, and the volume particle rendering path in pointgr.cpp already routes through Insert_Triangles with no gaps.

A grep across the entire repository finds zero callers of Insert_VolumeParticle after this change. The volume particle code in pointgr.cpp independently confirms it uses Insert_Triangles. Nothing is broken or left dangling by the removal.

No files require special attention.

Important Files Changed

Filename	Overview
Core/Libraries/Source/WWVegas/WW3D2/sortingrenderer.h	Declaration of Insert_VolumeParticle removed; remaining class interface is unchanged and correct.
Core/Libraries/Source/WWVegas/WW3D2/sortingrenderer.cpp	Implementation of Insert_VolumeParticle removed; grep confirms zero remaining callers in the repository.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Volume Particle Rendering\npointgr.cpp] -->|sort enabled| B[SortingRendererClass::Insert_Triangles]
    A -->|sort disabled| C[DX8Wrapper::Draw_Triangles]
    B --> D[Insert_To_Sorted_List]
    D --> E[Deferred Sorted Draw]

    style F fill:#ffcccc,stroke:#cc0000
    F[~~Insert_VolumeParticle~~\nREMOVED - never called]

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[Volume Particle Rendering\npointgr.cpp] -->|sort enabled| B[SortingRendererClass::Insert_Triangles]
    A -->|sort disabled| C[DX8Wrapper::Draw_Triangles]
    B --> D[Insert_To_Sorted_List]
    D --> E[Deferred Sorted Draw]

    style F fill:#ffcccc,stroke:#cc0000
    F[~~Insert_VolumeParticle~~\nREMOVED - never called]

Loading

_{Reviews (1): Last reviewed commit: "chore(sortingrenderer): Remove unused fu..." | Re-trigger Greptile}