fix(update): Fix laser-to-target setup mistake in AssistedTargetingUpdate

[Stubbjax]

This change fixes a copy-and-paste mistake in Zero Hour's AssistedTargetingUpdate module when reading template data, which causes the module's LaserToTarget field to use the value assigned to the LaserFromAssisted field.

This has no effect on retail games as all LaserFromAssisted and LaserToTarget fields share the same value regardless, as shown below.

Behavior = AssistedTargetingUpdate ModuleTag_XX
  LaserFromAssisted = PatriotBinaryDataStream ; Stream to draw from the requestor to me
  LaserToTarget = PatriotBinaryDataStream ; Stream to draw from me to the target
End

[greptile-apps]

Greptile Summary

This PR fixes a copy-paste bug in AssistedTargetingUpdate where m_laserToTarget was incorrectly initialized using d->m_laserFromAssistedName instead of d->m_laserToTargetName. The fix is applied consistently in both the update() and loadPostProcess() methods.

• The bug caused both laser template pointers to resolve to the same template (LaserFromAssisted), meaning LaserToTarget was silently ignored; with different template names these two lasers would have rendered identically.
• The fix is minimal and surgical — two single-field substitutions with no surrounding logic changes.

Confidence Score: 5/5

Safe to merge — the change is a targeted two-line fix with no side effects.

Both update() and loadPostProcess() now consistently resolve m_laserToTarget from its own named template field. The fix is correct, symmetrical, and touches no surrounding logic. The PR description also correctly notes this has no effect on retail data where both names share the same value, so there is no risk of regression in the shipped content.

No files require special attention.

Important Files Changed

Filename	Overview
GeneralsMD/Code/GameEngine/Source/GameLogic/Object/Update/AssistedTargetingUpdate.cpp	Corrects copy-paste error: m_laserToTarget now reads from d->m_laserToTargetName instead of d->m_laserFromAssistedName in both update() and loadPostProcess().

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[AssistedTargetingUpdate::update / loadPostProcess] --> B[Read m_laserFromAssistedName]
    B --> C[TheThingFactory::findTemplate]
    C --> D[m_laserFromAssisted]
    A --> E[Read m_laserToTargetName]
    E --> F[TheThingFactory::findTemplate]
    F --> G[m_laserToTarget]

    D --> H[makeFeedbackLaser: requestor -> me]
    G --> I[makeFeedbackLaser: me -> target]

    style E fill:#90EE90
    style G fill:#90EE90
    style I fill:#90EE90

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[AssistedTargetingUpdate::update / loadPostProcess] --> B[Read m_laserFromAssistedName]
    B --> C[TheThingFactory::findTemplate]
    C --> D[m_laserFromAssisted]
    A --> E[Read m_laserToTargetName]
    E --> F[TheThingFactory::findTemplate]
    F --> G[m_laserToTarget]

    D --> H[makeFeedbackLaser: requestor -> me]
    G --> I[makeFeedbackLaser: me -> target]

    style E fill:#90EE90
    style G fill:#90EE90
    style I fill:#90EE90

Loading

_{Reviews (1): Last reviewed commit: "fix: Fix copy-and-paste mistake in Assis..." | Re-trigger Greptile}

[xezon]

Looking good