Update fixInludesCase.sh#520
Closed
Mustafa1p wants to merge 1 commit into
Closed
Conversation
Improve the script by fixing typos, adding comments for better readability, and enhancing the logic for handling include paths.
DevGeniusCode
added
Tools
|
@zzambers Do we need this refactor? |
|
Fixing typos and avoiding cat makes sense. When it comes to additional space around commands in subshells, that is probably matter of taste. I am used to using extra spaces there for visual separation, but don't have strong preference. However if changes are made to this script, probably this should be fixed as well: #481 (comment) |
|
Is this PR still being considered? it seems redundant overall. |
|
PR has been abandoned , closing for now If the author wants to continue with this PR, they can reopen it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the script by fixing typos, adding comments for better readability, and enhancing the logic for handling include paths.