Skip to content

[GEN][ZH] Fix uninitialized variables in AiPathFind::findGroundPath, AiPathFind::classifyFence #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xezon merged 2 commits into from
Apr 28, 2025
Merged

[GEN][ZH] Fix uninitialized variables in AiPathFind::findGroundPath, AiPathFind::classifyFence #632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9037e08
[ZH] Fix partly uninitialized cellBounds variable in AIPathfind::clas…
Mauller Apr 8, 2025
7dc1a08
[GEN][ZH] Fix uninitialized costSoFar variable in AIPathfind::findGou…
Mauller Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Generals/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6649,7 +6649,7 @@ Path *Pathfinder::findGroundPath( const Coord3D *from,
const Int adjacent[5] = {0, 1, 2, 3, 0};
Bool neighborFlags[8] = {false, false, false, false, false, false, false};

UnsignedInt newCostSoFar;
UnsignedInt newCostSoFar = 0;

for( int i=0; i<numNeighbors; i++ )
{
Expand Down
4 changes: 3 additions & 1 deletion GeneralsMD/Code/GameEngine/Source/GameLogic/AI/AIPathfind.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4031,6 +4031,8 @@ void Pathfinder::classifyFence( Object *obj, Bool insert )
IRegion2D cellBounds;
cellBounds.lo.x = REAL_TO_INT_FLOOR((pos->x + 0.5f)/PATHFIND_CELL_SIZE_F);
cellBounds.lo.y = REAL_TO_INT_FLOOR((pos->y + 0.5f)/PATHFIND_CELL_SIZE_F);
cellBounds.hi.x = REAL_TO_INT_CEIL((pos->x + 0.5f)/PATHFIND_CELL_SIZE_F);
cellBounds.hi.y = REAL_TO_INT_CEIL((pos->y + 0.5f)/PATHFIND_CELL_SIZE_F);
Comment thread
Mauller marked this conversation as resolved.
Outdated
Bool didAnything = false;

for (Int iy = 0; iy < numStepsY; ++iy, tl_x += ydx, tl_y += ydy)
Expand Down Expand Up @@ -7190,7 +7192,7 @@ Path *Pathfinder::findGroundPath( const Coord3D *from,
const Int adjacent[5] = {0, 1, 2, 3, 0};
Bool neighborFlags[8] = {false, false, false, false, false, false, false};

UnsignedInt newCostSoFar;
UnsignedInt newCostSoFar = 0;
Comment thread
Mauller marked this conversation as resolved.
Outdated

for( int i=0; i<numNeighbors; i++ )
{
Expand Down