[GEN][ZH] Fix iterator usage in projectileHandleCollision functions#728
Merged
Conversation
feliwir
previously requested changes
Apr 21, 2025
Author
|
Rebased with main so ready for merging |
xezon
approved these changes
Apr 26, 2025
xezon
left a comment
xezon
left a comment
There was a problem hiding this comment.
We reviewed ContainedItemsList and no user adds null elements.
xezon
changed the title
…date to conform to STL Co-authored-by: Helmut Buhler <buhler@8gadgetpack.net>
…ileBehavior to conform to STL Co-authored-by: Helmut Buhler <buhler@8gadgetpack.net>
Author
|
Tweaked commit descriptions to be more specific and to include coauthor |
xezon
pushed a commit
that referenced
this pull request
Apr 27, 2025
…date to conform to STL (#728) Co-authored-by: Helmut Buhler <buhler@8gadgetpack.net>
xezon
pushed a commit
that referenced
this pull request
Apr 27, 2025
…ileBehavior to conform to STL (#728) Co-authored-by: Helmut Buhler <buhler@8gadgetpack.net>
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…date to conform to STL (TheSuperHackers#728) Co-authored-by: Helmut Buhler <buhler@8gadgetpack.net>
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…ileBehavior to conform to STL (TheSuperHackers#728) Co-authored-by: Helmut Buhler <buhler@8gadgetpack.net>
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Feb 23, 2026
…date to conform to STL (TheSuperHackers#728) Co-authored-by: Helmut Buhler <buhler@8gadgetpack.net>
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Feb 23, 2026
…ileBehavior to conform to STL (TheSuperHackers#728) Co-authored-by: Helmut Buhler <buhler@8gadgetpack.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This problem was originaly discovered by @helmutbuhler and has been split out of the original PR.
This commit corrects iterator usage to conform with STL iterator behaviour instead of STLport behaviours.