Skip to content

[GEN][ZH] Fix possible division by zero in W3DCommandBarGenExpDraw()#810

Merged
xezon merged 1 commit into
TheSuperHackers:mainfrom
Mauller:fix-zero-division-in-w3dcontrolbar
May 5, 2025
Merged

[GEN][ZH] Fix possible division by zero in W3DCommandBarGenExpDraw()#810
xezon merged 1 commit into
TheSuperHackers:mainfrom
Mauller:fix-zero-division-in-w3dcontrolbar

Conversation

@Mauller

@Mauller Mauller commented May 4, 2025 •
edited by xezon
Loading

Copy link
Copy Markdown

This PR prevents a possible division by zero from occuring when player progress is calculated.

@Mauller Mauller self-assigned this May 4, 2025
@Mauller Mauller added Bug Something is not working right, typically is user facing Minor Severity: Minor < Major < Critical < Blocker Gen Relates to Generals ZH Relates to Zero Hour Fix Is fixing something, but is not user facing and removed Bug Something is not working right, typically is user facing labels May 4, 2025
Skyaero42
Skyaero42 approved these changes May 5, 2025
View reviewed changes

@Skyaero42 Skyaero42 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@xezon xezon added Crash This is a crash, very bad Mod Relates to Mods or modding and removed Gen Relates to Generals ZH Relates to Zero Hour labels May 5, 2025
@Mauller Mauller force-pushed the fix-zero-division-in-w3dcontrolbar branch from b643498 to 15ff8ef Compare May 5, 2025 14:17
@Mauller

Mauller commented May 5, 2025

Copy link
Copy Markdown
Author

Tweaked and pushed.

xezon
xezon reviewed May 5, 2025
View reviewed changes
Comment thread Generals/Code/GameEngineDevice/Source/W3DDevice/GameClient/GUI/GUICallbacks/W3DControlBar.cpp Outdated
@Mauller Mauller force-pushed the fix-zero-division-in-w3dcontrolbar branch from 15ff8ef to e7f45ff Compare May 5, 2025 17:14
@xezon xezon added this to the Stability fixes milestone May 5, 2025
@xezon xezon merged commit afd9c30 into TheSuperHackers:main May 5, 2025
@xezon xezon deleted the fix-zero-division-in-w3dcontrolbar branch May 5, 2025 17:51
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Nov 10, 2025
@Mauller
[GEN][ZH] Fix possible division by zero in W3DCommandBarGenExpDraw() (T…
6b817df 
…heSuperHackers#810)
fbraz3 pushed a commit to fbraz3/GeneralsX that referenced this pull request Feb 23, 2026
@Mauller
[GEN][ZH] Fix possible division by zero in W3DCommandBarGenExpDraw() (T…
31c483e 
…heSuperHackers#810)
@Caball009 Caball009 mentioned this pull request Jul 12, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xezon xezon xezon approved these changes
@Skyaero42 Skyaero42 Skyaero42 approved these changes

Assignees

@Mauller Mauller

Labels

Crash This is a crash, very bad Fix Is fixing something, but is not user facing Minor Severity: Minor < Major < Critical < Blocker Mod Relates to Mods or modding

Projects

None yet

Milestone

Stability fixes

Development

Successfully merging this pull request may close these issues.

Division by zero crash in W3DCommandBarGenExpDraw() when experience points for level up are 0

3 participants

@Mauller @xezon @Skyaero42