[GEN][ZH] Workaround for checking 'this' pointer#865
Closed
Caball009 wants to merge 2 commits into
Closed
Conversation
Skyaero42
added
Gen
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking the
thispointer is undefined behavior and such checks may be elided by the compiler at any moment. Clang-cl doesn't check the pointer value (at higher optimization levels, at least), so the game crashes before it can get to the main menu.Using a volatile pointer will force the compiler to emit more instructions, so there'll be a very small but inevitable inefficiency.
This is a workaround, not a fix. The issue is that fixing this would probably require changing all 1000+ calls to
deleteInstance.