[GEN][ZH] Rename MemoryPoolObject::deleteInstance to MemoryPoolObject::deleteInstanceInternal#889
Merged
xezon merged 1 commit intoMay 21, 2025
Conversation
…::deleteInstanceInternal
xezon
added
Minor
Mauller
approved these changes
May 21, 2025
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…::deleteInstanceInternal (TheSuperHackers#889)
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Feb 23, 2026
…::deleteInstanceInternal (TheSuperHackers#889)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change renames
MemoryPoolObject::deleteInstancetoMemoryPoolObject::deleteInstanceInternal.Reason being, when overloading the global
deleteInstance, then a call todeleteInstancewithin a member function of a parent class ofMemoryPoolObjectwill callMemoryPoolObject::deleteInstanceinstead of::deleteInstance, which is confusing and error prone.