[GEN][ZH] Prevent game crash when starting a new game without a map#993
Merged
Merged
Conversation
…artPosition() when starting a new game without a map (#993)
…tNewGame() when starting a new game without a map (#993)
xezon
force-pushed
the
xezon/fix-replay-load-crash-2
branch
from
1b5e802 to
4710d51
Compare
1 task
Mauller
approved these changes
Jun 5, 2025
xezon
added a commit
that referenced
this pull request
Jun 6, 2025
…artPosition() when starting a new game without a map (#993)
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…artPosition() when starting a new game without a map (TheSuperHackers#993)
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Nov 10, 2025
…tNewGame() when starting a new game without a map (TheSuperHackers#993)
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Feb 23, 2026
…artPosition() when starting a new game without a map (TheSuperHackers#993)
fbraz3
pushed a commit
to fbraz3/GeneralsX
that referenced
this pull request
Feb 23, 2026
…tNewGame() when starting a new game without a map (TheSuperHackers#993)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with Rebase
This change fixes 2 null dereferences when attempting to load into a Replay whose map is missing. Loading in an empty map is not particularly useful, but it is better than crashing the game.
The first commit also fixes a warning from the MSVC static analyzer:
Loading into a Replay whose map is missing