Skip to content

Project view: entity disambiguation, roomier spacing, dashboard landing - #109

Merged
TraderSamwise merged 2 commits into
masterfrom
feat/ui-facelift-next
Jun 7, 2026
Merged

Project view: entity disambiguation, roomier spacing, dashboard landing#109
TraderSamwise merged 2 commits into
masterfrom
feat/ui-facelift-next

Conversation

@TraderSamwise

@TraderSamwise TraderSamwise commented Jun 7, 2026

Copy link
Copy Markdown
Owner

What

Follow-up polish on the project-view restyle (builds on #107).

Entity disambiguation (shape language, mirrors the TUI)

  • Worktree = thick-outline square, agent = filled circle, service = diamond + a service tag. Fill/outline color still encodes status (green = running, muted = idle, faint = empty). StatusDotMini gains shape/outline; new TypeTag.
  • Nesting: agents/services hang off a vertical guide line, indented under their worktree — in both the sidebar and the page.

Spacing

  • Page view drops the table-style row borders / header band and adopts the sidebar's flat list look, scaled ~20% roomier (padding, type, row height) for a main GUI surface. Sidebar bumped to match while staying a denser nav rail.

Dashboard as the canonical landing

  • Extracted the worktree dashboard into a shared components/WorktreeDashboard.tsx.
  • The Project screen's Dashboard is now the first pill and the default section.
  • Every landing path — root URL, default project, project switch — routes to /project's Dashboard section. The legacy standalone / dashboard route now <Redirect>s there. The sidebar Dashboard/Views tree toggle stays separate.

Behavior

Navigation, selection, and service actions are preserved. New interactions are additive (collapsible groups, empties disclosure, project-switch lands on /project dashboard).

Verification

yarn typecheck + lint clean on all changed files (pre-existing cli-auth.tsx lint error untouched). Validated locally in LOCAL_MODE against aimux-dev with live agents/services across desktop widths; per-page mobile polish deferred.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features

    • Introduced consolidated worktree dashboard view with grouped organization, collapsible sections, and status indicators.
  • UI/UX Updates

    • Enhanced sidebar styling with improved spacing, typography, and service status indicators.
    • Expanded status indicators with multiple shape variants and outline styling options.
    • Streamlined project navigation to route through the dashboard view.

Refine the project view restyle:

- Shape language (mirrors the TUI): worktree = thick-outline square, agent =
  filled circle, service = diamond + a "service" tag. Fill/outline color still
  encodes status (green = running). Adds StatusDotMini shape/outline + TypeTag.
- Nesting: agents/services hang off a vertical guide line indented under their
  worktree, in both the sidebar and the page.
- Page view adopts the sidebar's flat list look (no table borders / header band),
  scaled ~20% roomier (padding, type, row height) for a GUI surface; sidebar
  bumped to match while staying a denser nav rail.
- Extract the worktree dashboard into a shared WorktreeDashboard component.
- Make the Project screen's "Dashboard" the first pill and default section, and
  route every landing (root URL, default project, project switch) to
  /project's Dashboard section. The legacy standalone dashboard route redirects
  there.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@vercel

vercel Bot commented Jun 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Jun 7, 2026 10:56am

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 484eb70d-00ee-4211-9a19-7297976b11ab

📥 Commits

Reviewing files that changed from the base of the PR and between e39f203 and 4bd257a.

📒 Files selected for processing (5)
  • app/app/(main)/(tabs)/(dashboard)/index.tsx
  • app/app/(main)/(tabs)/project/index.tsx
  • app/components/ProjectSidebar.tsx
  • app/components/WorktreeDashboard.tsx
  • app/components/status-dot.tsx

📝 Walkthrough

Walkthrough

The PR converts a standalone dashboard route into a redirect endpoint and establishes a new project-scoped "dashboard" section. A new WorktreeDashboard component replaces the legacy dashboard UI, displaying worktrees grouped by bucket with collapsible agent and service rows. StatusDotMini is enhanced with shape and outline options. ProjectSidebar styling is updated throughout to support the new dashboard presentation.

Changes

Dashboard Route Migration and Component Refactor

Layer / File(s) Summary
Dashboard Route Navigation Refactor
app/app/(main)/(tabs)/(dashboard)/index.tsx, app/app/(main)/(tabs)/project/index.tsx, app/components/ProjectSidebar.tsx
DashboardIndex becomes a minimal redirect to the project's dashboard section. ProjectSection gains "dashboard" as the new default fallback. Project screen conditionally renders WorktreeDashboard when section equals "dashboard". ProjectSidebar project selection now routes to the project dashboard via buildViewHref("/project", { project: path }).
StatusDotMini UI Enhancement
app/components/status-dot.tsx
StatusDotMini signature expands to support optional shape (circle, square, diamond) and optional outline. Outline mode renders a thick border ring with status-based color (neutral gray when hollow). Component handles size and rounding adjustments per shape for both filled and outline visual modes.
WorktreeDashboard Component Implementation
app/components/WorktreeDashboard.tsx
New component renders worktrees grouped by bucket with collapsible headers and indented child rows. AgentRow and ServiceRow display sessions and services with status, labels, and action controls. WorktreeGroup computes bucket state and rendering. WorktreeList partitions buckets into main, active, and empty groups. Main component fetches Jotai state, async auth token, navigation handlers, and conditional early-exit screens before rendering the list.
ProjectSidebar Styling and UI Updates
app/components/ProjectSidebar.tsx
ProjectPicker and ProjectHeader styling updated (text sizing, ellipsizing, padding, borders). AgentRow typography and StatusDotMini placement restyled. ServiceRow restructured to include TypeTag label with diamond-shaped StatusDotMini. WorktreeGroup header styling updates chevron and outline logic. Child rows gain left indentation and border. Empty disclosure and tab styling updated. Imports reorganized.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • TraderSamwise/aimux#42: Both PRs update dashboard route navigation behavior; main PR converts the dashboard to a redirect-only endpoint, while #42 updates session/service handlers within the existing dashboard to use centralized detailHrefForPath.
  • TraderSamwise/aimux#59: Both PRs modify navigation "chrome" around project/dashboard screens—Refine web navigation chrome #59 adjusts initial tab/route behavior and sidebar patterns, while the main PR adds a worktree dashboard and updates DashboardIndex/ProjectSidebar to route selections to the project's dashboard view.
  • TraderSamwise/aimux#107: Both PRs overlap by modifying dashboard/sidebar entrypoints and the shared StatusDotMini implementation in app/components/status-dot.tsx, with the main PR additionally wiring the dashboard via a new WorktreeDashboard flow.

Poem

🐰 Hops through the halls of refactored view,
Dashboard redirects, project-scoped and new,
Worktrees grouped in collapsible delight,
StatusDots dancing in circle and diamond bright,
Navigation flows smooth—a routing delight!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 34.62% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: entity disambiguation (shape language), spacing improvements, and dashboard landing as the default project view.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/ui-facelift-next

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

app/app/(main)/(tabs)/(dashboard)/index.tsx

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.

app/app/(main)/(tabs)/project/index.tsx

ESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.

app/components/ProjectSidebar.tsx

ESLint skipped: the ESLint configuration for this file references a package that is not available in the sandbox.

  • 2 others

Comment @coderabbitai help to get the list of available commands and usage tips.

@TraderSamwise

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@TraderSamwise

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@TraderSamwise

Copy link
Copy Markdown
Owner Author

@coderabbitai full review

@coderabbitai

coderabbitai Bot commented Jun 7, 2026

Copy link
Copy Markdown
✅ Action performed

Full review finished.

…redirect

The standalone dashboard route now <Redirect>s to the Project screen's
Dashboard section, so the component is rendered only there; drop the stale
'dashboard route' references in the header/padded comments.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@TraderSamwise

Copy link
Copy Markdown
Owner Author

Review note (in-runtime): CodeRabbit reported its org is out of review credits / rate-limited (its summary comment shows "Review limit reached"), so its success commit status is a no-op — no review actually ran. Per the review workflow's self-review fallback, this PR was reviewed by an in-runtime sub-agent against 29a71e5. Findings and resolutions:

  1. WorktreeDashboard.tsx — stale "dashboard route" comments (low). The header/padded comments claimed the component renders at the standalone dashboard route, but that route now <Redirect>s to the Project screen's Dashboard section. → Fixed in 4bd257a — corrected the comments; kept the component route-agnostic/reusable.
  2. Lost host/endpoint indicator (low, behavior delta).By design — the Project screen already surfaces host-offline via its own "Project host offline" EmptyCard (project/index.tsx), so endpoint status is not lost.

No correctness, routing, redirect-loop, state-handling, key-collision, hook-dependency, or accessibility issues found. yarn typecheck and lint are clean on the changed files (pre-existing cli-auth.tsx lint error untouched).

@TraderSamwise
TraderSamwise merged commit 2753549 into master Jun 7, 2026
2 of 3 checks passed
@TraderSamwise
TraderSamwise deleted the feat/ui-facelift-next branch June 7, 2026 10:57
This was referenced Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant