Skip to content

Fix GUI smoke regressions - #266

Merged
TraderSamwise merged 2 commits into
masterfrom
chore/gui-smoke-next-10
Jun 28, 2026
Merged

Fix GUI smoke regressions#266
TraderSamwise merged 2 commits into
masterfrom
chore/gui-smoke-next-10

Conversation

@TraderSamwise

@TraderSamwise TraderSamwise commented Jun 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • preserve project query state across GUI primary navigation and slow fallback polling behind SSE/event updates
  • add stable accessible ids for worktree and agent-detail form fields
  • verified GUI routes, worktree create/remove, and read-only agent chat through Chrome DevTools MCP

Verification

  • yarn --cwd app typecheck
  • yarn --cwd app lint (existing warnings only)
  • yarn --cwd app test
  • yarn typecheck
  • push hook: yarn typecheck && yarn lint && yarn test (2039 tests)
  • yarn build:ui:local
  • local release install: local-826ea25, post-install repair 0 failures

Summary by CodeRabbit

  • Bug Fixes
    • Improved background refresh timing for project discovery, desktop-state fallback, and notifications so updates are more consistent.
    • Fixed navigation behavior in project and tab views to better preserve the current route when switching screens.
    • Improved form accessibility by adding clearer labels and more reliable focus targets across agent, teammate, and worktree panels.

@vercel

vercel Bot commented Jun 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Jun 28, 2026 11:19pm

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6b753c90-b509-401b-9c37-81ec5035590a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Splits a single 2 s polling constant into two named 10 s constants (PROJECT_LIST_POLL_INTERVAL_MS, PROJECT_VIEW_FALLBACK_POLL_INTERVAL_MS) and updates three polling effects to use them. Switches buildViewHref to buildViewPath in tab and sidebar navigation. Adds nativeID and accessibilityLabel props to form inputs in four panel components.

Changes

Polling interval split

Layer / File(s) Summary
Poll constants and loop updates
app/app/(main)/_layout.tsx
Replaces POLL_INTERVAL_MS = 2000 with two 10 s constants; updates /projects, /desktop-state, and notifications polling effects to use the appropriate constant.

Navigation path switch

Layer / File(s) Summary
buildViewHrefbuildViewPath
app/lib/main-tabs.ts, app/components/ProjectSidebar.tsx
Updates imports and router.replace calls in useMainTabNavigation and SidebarPrimaryNav to use buildViewPath instead of buildViewHref.

Accessibility IDs on form inputs

Layer / File(s) Summary
nativeID and accessibilityLabel on panel inputs
app/components/agent-management-panel.tsx, app/components/screens/AgentChatScreen.tsx, app/components/teammate-panel.tsx, app/components/worktree-management-panel.tsx
Derives sanitized fieldIdPrefix/composerFieldId from session.id or sessionKey; assigns stable nativeID and accessibilityLabel to Label, Loop goal, Message, Role, Task, and worktree name inputs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • TraderSamwise/aimux#50: Modifies the same three polling loops (/projects, /desktop-state, /notifications) in _layout.tsx, overlapping directly with the interval constant changes.
  • TraderSamwise/aimux#109: Modifies the same ProjectSidebar.tsx project-navigation handler and URL construction that this PR switches from buildViewHref to buildViewPath.

Poem

🐇 Two constants where one used to dwell,
Ten seconds each — a slower bell.
The path is built, not href'd today,
And every input finds its way.
With IDs stable, labels bright,
This rabbit hops toward a11y light! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and accurately reflects the PR’s goal of fixing GUI smoke regressions.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/gui-smoke-next-10

Comment @coderabbitai help to get the list of available commands.

@TraderSamwise

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@TraderSamwise
TraderSamwise merged commit 0285458 into master Jun 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant