Skip to content

Fix dashboard digit shortcuts - #258

Merged
TraderSamwise merged 1 commit into
masterfrom
chore/tui-smoke-next-2
Jun 27, 2026
Merged

Fix dashboard digit shortcuts#258
TraderSamwise merged 1 commit into
masterfrom
chore/tui-smoke-next-2

Conversation

@TraderSamwise

@TraderSamwise TraderSamwise commented Jun 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • make dashboard digit shortcuts match the currently visible entry list at session/item level
  • keep worktree-level digit shortcuts scoped to visible worktrees
  • remove the obsolete buffered quick-jump timeout path and update footer labels

Verification

  • yarn vitest src/multiplexer/dashboard-interaction.test.ts src/tui/screens/dashboard-renderers.test.ts src/dashboard/quick-jump.test.ts
  • yarn typecheck
  • yarn lint
  • yarn vitest
  • AIMUX_RELEASE_VERSION=0.1.21-local-smoke53 yarn release:asset && scripts/install.sh release/aimux-darwin-arm64.tar.gz
  • manual TUI smoke: digit 6 opens shell service, service restore/stop settles cleanly

Summary by CodeRabbit

  • New Features

    • Numeric shortcuts now jump immediately to the selected entry or worktree, making dashboard navigation faster and more direct.
    • Shortcut hints now show clearer labels for the active level, distinguishing between entry-level and worktree-level actions.
  • Bug Fixes

    • Removed delayed quick-jump behavior so key presses respond consistently without needing a timeout.
  • Tests

    • Added coverage for numeric shortcut handling at both session and worktree levels.

@vercel

vercel Bot commented Jun 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Jun 27, 2026 3:46pm

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

No new commits to review since the last review.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 886636d8-3ce8-46e2-beff-b7985e867ada

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

Removes the buffered multi-digit quick-jump mechanism (timeout constant, class field, commitDashboardQuickJump, auto-commit on non-digit key) and replaces it with immediate single-digit navigation in handleDashboardQuickJumpDigit. Footer hint labels for 1-9 keys are updated from "jump" to "entry" or "worktree" depending on nav level.

Immediate single-digit quick-jump navigation

Layer / File(s) Summary
Remove timeout constant and class field
src/dashboard/quick-jump.ts, src/multiplexer/index.ts
Deletes DASHBOARD_QUICK_JUMP_TIMEOUT_MS and HOTKEY_TIMEOUT_MS import, and removes the dashboardQuickJumpTimeout private field from Multiplexer.
Rewrite handleDashboardQuickJumpDigit to immediate navigation
src/multiplexer/dashboard-interaction.ts
Switches to standalone import for buildDashboardQuickJumpWorktrees, rewrites clearDashboardQuickJump to reset digits only, rewrites handleDashboardQuickJumpDigit for immediate single-digit action at sessions or worktrees level, expands handleDashboardKey break condition for digit keys, and removes auto-commit of buffered digits.
Update footer hint labels and tests
src/tui/screens/dashboard-renderers.ts, src/tui/screens/dashboard-renderers.test.ts
Changes 1-9 hint label from "jump" to "entry" at sessions level and "worktree" at worktrees level, with a new test asserting both values.
Tests for immediate digit navigation
src/multiplexer/dashboard-interaction.test.ts
Adds session-level digit test verifying sessionIndex update and entry activation, and worktree-level digit test verifying focusedWorktreePath and renderDashboard call.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • TraderSamwise/aimux#141: Adds per-agent quick-jump index digits in dashboard-renderers.ts, directly related to the same digit navigation UX this PR rewrites.
  • TraderSamwise/aimux#165: Introduces buildDashboardFooterHints/renderFooterHints model in dashboard-renderers.ts that this PR modifies for the 1-9 hint labels.

Poem

🐇 No more waiting, no more delay,
One digit pressed and you're on your way!
The timeout vanished, the buffer is gone,
Jump to your entry and carry on.
Hop! 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: fixing dashboard digit shortcut behavior.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/tui-smoke-next-2

Comment @coderabbitai help to get the list of available commands.

@TraderSamwise

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@TraderSamwise
TraderSamwise merged commit 4bf38dc into master Jun 27, 2026
3 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Jun 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant