Skip to content

Fix TUI smoke regressions - #259

Merged
TraderSamwise merged 5 commits into
masterfrom
chore/tui-smoke-next-3
Jun 28, 2026
Merged

Fix TUI smoke regressions#259
TraderSamwise merged 5 commits into
masterfrom
chore/tui-smoke-next-3

Conversation

@TraderSamwise

@TraderSamwise TraderSamwise commented Jun 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • normalize LF as Enter for terminal key input
  • refresh dashboard help shortcuts to match current dashboard-local controls
  • avoid fake Project counts before API data loads
  • map dashboard digit activation to the rendered row order

Verification

  • yarn vitest src/multiplexer/dashboard-interaction.test.ts src/tui/screens/dashboard-renderers.test.ts
  • yarn vitest src/project-observability.test.ts src/tui/screens/subscreen-renderers.test.ts src/multiplexer/project.test.ts
  • yarn typecheck
  • yarn lint
  • yarn vitest
  • AIMUX_RELEASE_VERSION=0.1.21-local-smoke59 yarn release:asset && scripts/install.sh release/aimux-darwin-arm64.tar.gz
  • manual tmux smoke: dashboard row digit activation opens the selected live Codex window; Project screen settles to API-backed counts

Summary by CodeRabbit

  • New Features
    • Updated the Help overlay with refreshed dashboard-mode keyboard shortcuts and actions.
    • Added a “Loading project...” view while project observability data is being prepared.
  • Bug Fixes
    • Improved keyboard mapping for newline inputs so Enter/Alt+Enter are recognized consistently.
    • Refined dashboard quick-jump so number keys map directly and reliably in session-level mode.
    • Updated project activity/agent running counts to include additional “ready” session states.
  • Tests
    • Expanded key parsing, dashboard quick-jump, and UI rendering test coverage to match the new behavior.

@vercel

vercel Bot commented Jun 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
app Ready Ready Preview, Comment Jun 28, 2026 2:34am

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7745254a-0251-41e8-a4c4-be5eecdb12ba

📥 Commits

Reviewing files that changed from the base of the PR and between 983bf9b and 8d46dd3.

📒 Files selected for processing (2)
  • src/multiplexer/project.test.ts
  • src/multiplexer/project.ts
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/multiplexer/project.ts

📝 Walkthrough

Walkthrough

LF now normalizes to enter in key parsing, dashboard session digit quick-jump maps directly to sessionIndex, project observability counts "ready" sessions as running and the project screen shows a loading state before data arrives, and the help overlay text now lists direct dashboard keybindings.

Changes

Dashboard, project, and overlay updates

Layer / File(s) Summary
LF normalized to enter
src/key-parser.ts, src/key-parser.test.ts
ESC+char and plain control-character parsing now map LF to enter, and tests expect enter and alt+enter instead of ctrl+j variants.
Sessions digit quick-jump
src/multiplexer/dashboard-interaction.ts, src/multiplexer/dashboard-interaction.test.ts
Session-level digit quick-jump now sets sessionIndex directly from the digit, then selects, persists, and activates the matching worktree entry; the related test verifies the new ordering and activation path.
Project loading state and observability rollup
src/project-observability.ts, src/project-observability.test.ts, src/tui/screens/subscreen-renderers.ts, src/tui/screens/subscreen-renderers.test.ts, src/multiplexer/project.ts, src/multiplexer/project.test.ts
Project observability counts ready sessions as running, and the project screen now renders a loading state until observability data is loaded; showProject and renderProject stop calling ensureProjectObservability directly.
Dashboard help keybindings
src/tui/screens/overlay-renderers.ts, src/tui/screens/overlay-renderers.test.ts
The dashboard help overlay replaces Ctrl+A-prefixed shortcut text with direct keybinding entries, and the overlay test checks the updated content.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • TraderSamwise/aimux#258: Directly modifies dashboard-interaction.ts and its tests to change how digit keys 1–9 perform quick-jump/selection at the dashboard level.
  • TraderSamwise/aimux#158: Introduces the project observability screen wiring that this PR extends with a loading state and updated agentsRunning rollup.
  • TraderSamwise/aimux#136: Refactors buildHelpOverlayOutput rendering infrastructure that this PR modifies to update dashboard keybinding text.

Poem

🐇 A newline hopped in and said, “Call me Enter!”
The parser agreed; the keys all feel gentler.
Digits now jump straight to the right seat,
While loading waits softly for data complete.
The help screen says “press this” in plain light anew—
This bunny approves of the tidy review!

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 10.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is concise and clearly matches the PR’s goal of fixing terminal UI smoke-test regressions.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/tui-smoke-next-3

Comment @coderabbitai help to get the list of available commands.

@TraderSamwise

Copy link
Copy Markdown
Owner Author

Independent review finding fixed in 8d46dd3: Project now redraws after first-load fallback is applied, so an invalid or fallback service response does not leave the Project screen stuck on Loading.

@TraderSamwise
TraderSamwise merged commit 4fda424 into master Jun 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant