Removing duplicate enumeration (thanks to David)#509
Merged
Conversation
btw something is wrong with xsd\netex_part_1\part1_ifopt\netex_ifopt_equipmentAccess_support.xsd in next
skinkie
added
the
bug
Contributor
Author
|
@Aurige There is a change in an enum being pantographABove to pantograph, I don't see pantograph ever used in the documentation. |
ue71603
approved these changes
Sep 28, 2023
trurlurl
approved these changes
Sep 28, 2023
Contributor
trurlurl
left a comment
trurlurl
left a comment
There was a problem hiding this comment.
I cannot judge, however, whether the depreciation note wasn't perhaps justified...
Aurige
reviewed
Sep 28, 2023
Contributor
Aurige
left a comment
Aurige
left a comment
There was a problem hiding this comment.
I would prefer keeping pantographABove (once only of course)
Contributor
Author
That would certainly be a typo. pantographAbove is something I can live with. |
ue71603
reviewed
Oct 4, 2023
Aurige
approved these changes
Oct 4, 2023
…tEnergy_support.xsd Co-authored-by: Matthias Günter <matthias.guenter@sbb.ch>
ue71603
approved these changes
Oct 4, 2023
skinkie
added a commit
that referenced
this pull request
Nov 21, 2023
* Update netex_nm_vehicleMeetingPointAssignment_support.xsd (#506) Co-authored-by: ue71603 <matthias.guenter@sbb.ch> * Fix improve mode (#507) * First draft of the clean up of MODE * Better explanations in VEHICLE MODE * AccessMode now works TRANSFERs and OTHER LEG (for OJP) * Some depreciations * added a mode to Connection * Update netex_mode_support.xsd Deprecated not Depreciated ;-) * Update netex_submode_version.xsd Deprecated not Depreciated ;-) * Apply suggestions from code review * Lint and update documentation tables * Update xsd/netex_framework/netex_reusableComponents/netex_mode_support.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com> * Update xsd/netex_framework/netex_reusableComponents/netex_mode_support.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com> --------- Co-authored-by: ue71603 <matthias.guenter@sbb.ch> Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com> * Fix passenger information equipment list (#510) * The connection exists in the documentation, but was not done in the xsd NeTEx part 1, figure 628 * Fixed according to Christophe's proposal * Apply suggestions from code review * Update xsd/netex_part_1/part1_tacticalPlanning/netex_passengerInformationEquipment_version.xsd * Lint and update documentation tables --------- Co-authored-by: ue71603 <matthias.guenter@sbb.ch> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * Fix typo's (#511) * Introduce VAT (#516) * Introduce VAT number * Removing duplicate enumeration (thanks to David) (#509) * Removing duplicate enumeration (thanks to David) btw something is wrong with xsd\netex_part_1\part1_ifopt\netex_ifopt_equipmentAccess_support.xsd in next * Lint and update documentation tables * Update xsd/netex_framework/netex_reusableComponents/netex_nm_equipmentEnergy_support.xsd Co-authored-by: Matthias Günter <matthias.guenter@sbb.ch> --------- Co-authored-by: ue71603 <matthias.guenter@sbb.ch> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> * enhancement-TMTC-add ACCEPTED DRIVER PERMITs Add ACCEPTED DRIVER PERMITS to VEHICEL TYpe * lint * revert non-changes * revert non-changes * Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com> * Apply suggestions from code review * Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd * Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com> * Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd * Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd Co-authored-by: Stefan de Konink <stefan@konink.de> * Update xsd/netex_framework/netex_reusableComponents/netex_vehicleType_version.xsd Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com> --------- Co-authored-by: ue71603 <matthias.guenter@sbb.ch> Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com> Co-authored-by: Nicholas Knowles <nick.knowles@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #372 (Directly on master)