Enh driver permit#545
Merged
Merged
Conversation
Co-authored-by: ue71603 <matthias.guenter@sbb.ch>
* First draft of the clean up of MODE * Better explanations in VEHICLE MODE * AccessMode now works TRANSFERs and OTHER LEG (for OJP) * Some depreciations * added a mode to Connection * Update netex_mode_support.xsd Deprecated not Depreciated ;-) * Update netex_submode_version.xsd Deprecated not Depreciated ;-) * Apply suggestions from code review * Lint and update documentation tables * Update xsd/netex_framework/netex_reusableComponents/netex_mode_support.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com> * Update xsd/netex_framework/netex_reusableComponents/netex_mode_support.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com> --------- Co-authored-by: ue71603 <matthias.guenter@sbb.ch> Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
* The connection exists in the documentation, but was not done in the xsd NeTEx part 1, figure 628 * Fixed according to Christophe's proposal * Apply suggestions from code review * Update xsd/netex_part_1/part1_tacticalPlanning/netex_passengerInformationEquipment_version.xsd * Lint and update documentation tables --------- Co-authored-by: ue71603 <matthias.guenter@sbb.ch> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
* Introduce VAT number
* Removing duplicate enumeration (thanks to David) btw something is wrong with xsd\netex_part_1\part1_ifopt\netex_ifopt_equipmentAccess_support.xsd in next * Lint and update documentation tables * Update xsd/netex_framework/netex_reusableComponents/netex_nm_equipmentEnergy_support.xsd Co-authored-by: Matthias Günter <matthias.guenter@sbb.ch> --------- Co-authored-by: ue71603 <matthias.guenter@sbb.ch> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Add ACCEPTED DRIVER PERMITS to VEHICEL TYpe
skinkie
added
enhancement
ue71603
approved these changes
Nov 6, 2023
trurlurl
reviewed
Nov 6, 2023
…_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
skinkie
commented
Nov 6, 2023
skinkie
commented
Nov 6, 2023
skinkie
commented
Nov 6, 2023
skinkie
commented
Nov 6, 2023
ue71603
approved these changes
Nov 6, 2023
trurlurl
requested changes
Nov 6, 2023
Contributor
Next is obviously better since it is an enhancement |
…_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Contributor
Author
skinkie
commented
Nov 6, 2023
skinkie
commented
Nov 6, 2023
…_version.xsd Co-authored-by: Stefan de Konink <stefan@konink.de>
Aurige
reviewed
Nov 10, 2023
Contributor
Aurige
left a comment
Aurige
left a comment
There was a problem hiding this comment.
I'm just reviewing netex_vehicle_type_xxx.xsd (everything else seems to come from a stack of previous PR initially target to main, but now brought back to next, right ?)
Contributor
|
The AcceptedDriverPermitRef is defined but not used anywhere .. also the AcceptedDriverPermit is a DataManagedObject so it would be Ok to keep this possibility for possible future use if you prefer (but I don't see much use case for us, I personally would rather remove it) |
…_version.xsd Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com>
ue71603
approved these changes
Nov 21, 2023
Aurige
approved these changes
Nov 21, 2023
Contributor
|
Part 1 and Part 5 document updated |
Aurige
added
document has been updated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@nick-knowles targeted in #408 master, should this be master or next?