Deckplan seating plan (redo of 571, 574 and 575)#615
Closed
ue71603 wants to merge 14 commits into
Closed
Conversation
ue71603
added
enhancement
This was referenced Dec 16, 2023
trurlurl
reviewed
Dec 29, 2023
| </xsd:annotation> | ||
| <xsd:restriction base="xsd:normalizedString"> | ||
| <xsd:enumeration value="forwards"/> | ||
| <xsd:enumeration value="backwards"/> |
Contributor
There was a problem hiding this comment.
I've seen trains in Spain with convertible seats such that the passenger(s) can choose between forwards and backwards. Add forwardsBackwardsSelectable?
| <xsd:sequence> | ||
| <xsd:element name="Length" type="LengthType" minOccurs="0"> | ||
| <xsd:annotation> | ||
| <xsd:documentation>Length of bedt back from seat bottom.</xsd:documentation> |
| <xsd:documentation>Allowed values for type of epassenger space.</xsd:documentation> | ||
| </xsd:annotation> | ||
| <xsd:restriction base="xsd:normalizedString"> | ||
| <xsd:enumeration value="seat"/> |
Contributor
There was a problem hiding this comment.
What about convertible / retractable seats that switch between seat and wheelchairSpace, seat and standingSpace, seat and pushchairSpace or bicycleSpace? Or space that can be used as any of that?
I haven't found where the enums are used. If they could be used with cardinality unbounded, then it would work by specifying multiple values.
…_support.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…_support.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
…nt_version.xsd Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
Contributor
Author
|
will be done with #656 |
Contributor
|
Removing "needs documentation update" label since closed without having been merged. |
trurlurl
removed
the
needs documentation update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
redo of #571 #574 and #575
Pay attention there is something that is not working. I had to comment two lines out from #574.
in xsd/netex_part_3/part3_fares/netex_accessRightParameter_version.xsd
A deep check by @Aurige and @nick-knowles is necessary
I did not recheck #415 , #414, #413 and #412 but just closed them.
575 contained
fa43f0f
0eddb08
29ee965
532c9b
574 contained
"4247f2b
3b2cac2"
0eddb08
29ee965
532c9b
571 contained
0eddb08
29ee965
532c9be