Skip to content

Enhancement for Site - site levels etc#575

Closed
nick-knowles wants to merge 15 commits into
TransmodelEcosystem:nextfrom
nick-knowles:enhancement-SiteLevels
Closed

Enhancement for Site - site levels etc#575
nick-knowles wants to merge 15 commits into
TransmodelEcosystem:nextfrom
nick-knowles:enhancement-SiteLevels

Conversation

@nick-knowles
Copy link
Copy Markdown
Contributor

TM enhancement to support different level names in a SIte: Add SIteStructure, LevelInStructure
Also GroupOfSItes and GroupOfTariffZoness added to SIteFrame
Add uniqueness constraints for new elements. Test case example provided

skinkie and others added 15 commits September 27, 2023 21:47
* First draft of the clean up of MODE

* Better explanations in VEHICLE MODE
* AccessMode now works TRANSFERs and OTHER LEG (for OJP)
* Some depreciations

* added a mode to Connection

* Update netex_mode_support.xsd

Deprecated not Depreciated ;-)

* Update netex_submode_version.xsd

Deprecated not Depreciated ;-)

* Apply suggestions from code review

* Lint and update documentation tables

* Update xsd/netex_framework/netex_reusableComponents/netex_mode_support.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>

* Update xsd/netex_framework/netex_reusableComponents/netex_mode_support.xsd

Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>

---------

Co-authored-by: ue71603 <matthias.guenter@sbb.ch>
Co-authored-by: Christophe Duquesne <christophe.duquesne@aurigetech.com>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: trurlurl <82838870+trurlurl@users.noreply.github.com>
* The connection exists in the documentation, but was not done in the xsd

NeTEx part 1, figure 628

* Fixed according to Christophe's proposal

* Apply suggestions from code review

* Update xsd/netex_part_1/part1_tacticalPlanning/netex_passengerInformationEquipment_version.xsd

* Lint and update documentation tables

---------

Co-authored-by: ue71603 <matthias.guenter@sbb.ch>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…#509)

* Removing duplicate enumeration (thanks to David)

btw something is wrong with  xsd\netex_part_1\part1_ifopt\netex_ifopt_equipmentAccess_support.xsd in next

* Lint and update documentation tables

* Update xsd/netex_framework/netex_reusableComponents/netex_nm_equipmentEnergy_support.xsd

Co-authored-by: Matthias Günter <matthias.guenter@sbb.ch>

---------

Co-authored-by: ue71603 <matthias.guenter@sbb.ch>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
annotation correction to clarify that Gradients are in degrees
Rbaseddeck plane ready to fix
DeckPlanc hanges. Rebased on current next
Minor changes to align with TM: move sensorInENtrance and spot to different packges

Also correctons to documentation
Adds SIteStructure to allow alternative labelling of levels within a site. Also GroupOfSItes and GroupOfTariffZones  added to SiteFrame. Test example also provided
@skinkie
Copy link
Copy Markdown
Contributor

skinkie commented Dec 12, 2023

@nick-knowles this way you work, reviewing and merging does not. Please only do a single change and always start from the current state of the branch you target.

@Aurige
Copy link
Copy Markdown
Contributor

Aurige commented Dec 12, 2023

I'm a bit lost here ... I guess only the last commit is relevant (so it's best to have only this one in a dedicated branch for the PR: you should be able to create such a branch on top of the current state of 'next' and cherry pick the relevant commit to this new branch. From there you can create a new PR)
This last commit adds a LevelInStructureRef but I can't find where it is used. Is there anything missing ?

@ue71603
Copy link
Copy Markdown
Contributor

ue71603 commented Dec 16, 2023

done in #615

@ue71603 ue71603 closed this Dec 16, 2023
@nick-knowles
Copy link
Copy Markdown
Contributor Author

UML documentation

image

@skinkie skinkie mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants