Skip to content

Prioritize TAP TSI validation#743

Merged
skinkie merged 5 commits into
masterfrom
fix_taptsi_examples
Dec 10, 2024
Merged

Prioritize TAP TSI validation#743
skinkie merged 5 commits into
masterfrom
fix_taptsi_examples

Conversation

@skinkie
Copy link
Copy Markdown
Contributor

@skinkie skinkie commented Jun 26, 2024

No description provided.

@ue71603
Copy link
Copy Markdown
Contributor

ue71603 commented Jun 27, 2024

...I duplicated your work....

@skinkie
Copy link
Copy Markdown
Contributor Author

skinkie commented Jun 27, 2024

...I duplicated your work....

Did you get paid for it?

@skinkie skinkie closed this Jul 25, 2024
@ue71603 ue71603 reopened this Oct 15, 2024
@ue71603
Copy link
Copy Markdown
Contributor

ue71603 commented Oct 15, 2024

@Aurige @skinkie I updated everything exept two files
Netex_tap_trainhotel_1.xml and Netex_tap_tsi-B2-71-optimised.xml

The have a different problem
The assume there are:

  • validityParameterAssignments/GenericParameterAssignmentRef
  • noticeAssignments/NoticeAssignmentRef
  • FareStructureElement/accessRightParameterAssignments
  • other fare stuff

It seems to me that those reference something that doesn't exist.

Perhaps @nick-knowles can have a go at it. But I think these two examples not to be reexamined.

@ue71603 ue71603 added this to the netex_2.0 milestone Oct 15, 2024
@ue71603 ue71603 added the bug Technical mistake, inconsistency with the documentation, etc. label Oct 15, 2024
Copy link
Copy Markdown
Contributor

@EU-Agency-for-Railways EU-Agency-for-Railways left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes OK for File Netex_tap_tsi_B2-71-optimised.xml and Netex_tap_trainhotel_1.xml @nick-knowles could check the errors

@Aurige
Copy link
Copy Markdown
Contributor

Aurige commented Oct 29, 2024

@nick-knowles to check why de 2 blocking files are not in the XML Spy project

@ue71603
Copy link
Copy Markdown
Contributor

ue71603 commented Nov 30, 2024

No answer from @nick-knowles . Files removed and ready to merge.

@skinkie skinkie merged commit 8ff04e2 into master Dec 10, 2024
@skinkie skinkie deleted the fix_taptsi_examples branch December 10, 2024 22:18
skinkie added a commit that referenced this pull request Feb 1, 2026
* Prioritize TAP TSI validation

* fixing examples part1

* deprecated invalid examples

* Lint and update documentation tables

---------

Co-authored-by: Matthias Günter <matthias.guenter@sbb.ch>
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Technical mistake, inconsistency with the documentation, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants