TAP TSI Example validation#754
Merged
Merged
Conversation
There were some real errors in some examples that were not catched before (reused ID, bad references...), and also a missed deprecation on enumeration values. Solving these seems to solve the TAP TSI example validation issues.
Contributor
|
This should go into master? |
Contributor
Author
|
not for the deprecations ... but we can also update the examples in master |
skinkie
approved these changes
Jul 24, 2024
skinkie
added
the
bug
ue71603
approved these changes
Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some real errors in some examples that were not catched before (reused ID, bad references...), and also a missed deprecation on enumeration values. Correcting these seems to solve the TAP TSI example validation issues.
Should solve #743