fix(acp-nats): preserve typed NATS subject contracts - #150
Conversation
yordis
commented
May 6, 2026
- Preserve compile-time subject routing guarantees at the ACP client proxy boundary.
- Keep canonical NATS subject serialization centralized in the ACP helper layer.
PR SummaryMedium Risk Overview Splits client-proxy subject markers into Reviewed by Cursor Bugbot for commit e13d884. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Coverage SummaryDetailsDiff against mainResults for commit: e13d884 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
88c4874 to
e13d884
Compare
Resolves all conflicts from 5 commits: - refactor(gateway): consolidate source adapters (#153) - feat(mcp-nats): support distributed MCP (#149) - refactor(telemetry): generalize service instrumentation (#152) - fix(signal): share shutdown boundary (#151) - fix(acp-nats): preserve typed NATS subject contracts (#150) Key decisions: - trogon-source-* Cargo.toml files deleted (accepted gateway consolidation) - acp-nats-server: accepted origin/main (registry routing removed by fix #150) - trogon-telemetry: generic resource_attributes API accepted (fix #152) - service_name.rs: combined AcpNatsWs + McpNatsStdio/McpNatsServer variants - Platform crates migrated from acp-telemetry to trogon-telemetry - signal::shutdown_signal moved from acp-telemetry to trogon-std - Orphaned trogon-source-* dirs excluded from workspace (tests preserved)
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Resolves all conflicts from 5 commits: - refactor(gateway): consolidate source adapters (#153) - feat(mcp-nats): support distributed MCP (#149) - refactor(telemetry): generalize service instrumentation (#152) - fix(signal): share shutdown boundary (#151) - fix(acp-nats): preserve typed NATS subject contracts (#150) Key decisions: - trogon-source-* Cargo.toml files deleted (accepted gateway consolidation) - acp-nats-server: accepted origin/main (registry routing removed by fix #150) - trogon-telemetry: generic resource_attributes API accepted (fix #152) - service_name.rs: combined AcpNatsWs + McpNatsStdio/McpNatsServer variants - Platform crates migrated from acp-telemetry to trogon-telemetry - signal::shutdown_signal moved from acp-telemetry to trogon-std - Orphaned trogon-source-* dirs excluded from workspace (tests preserved) Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>