fix(signal): share shutdown boundary - #151
Merged
Merged
Conversation
yordis
commented
May 6, 2026
yordis
commented
Member
- Keep process shutdown handling owned by the shared runtime boundary instead of an ACP-specific telemetry crate.
- Let ACP binaries and the gateway depend on the same signal behavior without coupling shutdown to telemetry.
PR SummaryMedium Risk Overview
Reviewed by Cursor Bugbot for commit 3974449. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
Warning Rate limit exceeded
To continue reviewing without waiting, purchase usage credits in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (11)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Code Coverage SummaryDetailsDiff against mainResults for commit: 3974449 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
yordis
force-pushed
the
yordis/fix-shared-signal
branch
2 times, most recently
from
May 6, 2026 06:45
d9fece9 to
c56f92b
Compare
yordis
added
the
rust:coverage-baseline-reset
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
force-pushed
the
yordis/fix-shared-signal
branch
from
May 6, 2026 06:59
c56f92b to
3974449
Compare
mariorha
added a commit
that referenced
this pull request
May 12, 2026
Resolves all conflicts from 5 commits: - refactor(gateway): consolidate source adapters (#153) - feat(mcp-nats): support distributed MCP (#149) - refactor(telemetry): generalize service instrumentation (#152) - fix(signal): share shutdown boundary (#151) - fix(acp-nats): preserve typed NATS subject contracts (#150) Key decisions: - trogon-source-* Cargo.toml files deleted (accepted gateway consolidation) - acp-nats-server: accepted origin/main (registry routing removed by fix #150) - trogon-telemetry: generic resource_attributes API accepted (fix #152) - service_name.rs: combined AcpNatsWs + McpNatsStdio/McpNatsServer variants - Platform crates migrated from acp-telemetry to trogon-telemetry - signal::shutdown_signal moved from acp-telemetry to trogon-std - Orphaned trogon-source-* dirs excluded from workspace (tests preserved)
yordis
added a commit
that referenced
this pull request
Jun 16, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
added a commit
that referenced
this pull request
Jun 22, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
added a commit
that referenced
this pull request
Jun 22, 2026
Resolves all conflicts from 5 commits: - refactor(gateway): consolidate source adapters (#153) - feat(mcp-nats): support distributed MCP (#149) - refactor(telemetry): generalize service instrumentation (#152) - fix(signal): share shutdown boundary (#151) - fix(acp-nats): preserve typed NATS subject contracts (#150) Key decisions: - trogon-source-* Cargo.toml files deleted (accepted gateway consolidation) - acp-nats-server: accepted origin/main (registry routing removed by fix #150) - trogon-telemetry: generic resource_attributes API accepted (fix #152) - service_name.rs: combined AcpNatsWs + McpNatsStdio/McpNatsServer variants - Platform crates migrated from acp-telemetry to trogon-telemetry - signal::shutdown_signal moved from acp-telemetry to trogon-std - Orphaned trogon-source-* dirs excluded from workspace (tests preserved) Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
added a commit
that referenced
this pull request
Jun 22, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
added a commit
that referenced
this pull request
Jun 23, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
added a commit
that referenced
this pull request
Jun 23, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
added a commit
that referenced
this pull request
Jun 23, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
added a commit
that referenced
this pull request
Jun 25, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
added a commit
that referenced
this pull request
Jun 25, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
added a commit
that referenced
this pull request
Jun 26, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
added a commit
that referenced
this pull request
Jun 26, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
added a commit
that referenced
this pull request
Jun 26, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
added a commit
that referenced
this pull request
Jun 26, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
yordis
added a commit
that referenced
this pull request
Jun 26, 2026
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.