Remove deprecated use of Actor.actor#157
Merged
UshakovVasilii merged 1 commit intoUshakovVasilii:masterfrom Dec 16, 2019
Merged
Remove deprecated use of Actor.actor#157UshakovVasilii merged 1 commit intoUshakovVasilii:masterfrom
UshakovVasilii merged 1 commit intoUshakovVasilii:masterfrom
Conversation
In Gnome 3.34 accessing <object>.actor results in a warning: Usage of object.actor is deprecated for Freon_FreonMenuButton get@resource:///org/gnome/shell/ui/environment.js:249:29 _init@[...]/freon@UshakovVasilii_Github.yahoo.com/extension.js:96:9 enable@[...]/freon@UshakovVasilii_Github.yahoo.com/extension.js:637:17 _callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:148:13 loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:280:21 _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:490:13 collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:27:17 _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:469:9 _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:499:13 _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:530:13 init@resource:///org/gnome/shell/ui/extensionSystem.js:48:9 _initializeUI@resource:///org/gnome/shell/ui/main.js:242:5 start@resource:///org/gnome/shell/ui/main.js:138:5 @<main>:1:31 The actor property is no longer needed, as Freon_FreonMenuButton already is an Actor. Additionally, we only support old Gnome versions on the Freon versions of the same era, so we do not need to worry about backwards compatibility (see UshakovVasilii#153). Reported-by: @49studebaker Fixes: UshakovVasilii#156 ("JS WARNING: " [...]) Related: https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/487 ("this.actor = this removal")
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Gnome 3.34 accessing
<object>.actorresults in a warning:The
actorproperty is no longer needed, asFreon_FreonMenuButtonalreadyis an Actor.
Additionally, we only support old Gnome versions on the Freon versions of the
same era, so we do not need to worry about backwards compatibility (see #153).
Reported-by: @49studebaker
Fixes: #156 ("JS WARNING: " [...])
Related: https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/487 ("this.actor = this removal")