Skip to content

Remove deprecated use of Actor.actor #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
UshakovVasilii merged 1 commit into from
Dec 16, 2019
Merged

Remove deprecated use of Actor.actor #157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Remove deprecated use of Actor.actor 
In Gnome 3.34 accessing <object>.actor results in a warning:

Usage of object.actor is deprecated for Freon_FreonMenuButton
get@resource:///org/gnome/shell/ui/environment.js:249:29
_init@[...]/freon@UshakovVasilii_Github.yahoo.com/extension.js:96:9
enable@[...]/freon@UshakovVasilii_Github.yahoo.com/extension.js:637:17
_callExtensionEnable@resource:///org/gnome/shell/ui/extensionSystem.js:148:13
loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:280:21
_loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:490:13
collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:27:17
_loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:469:9
_enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:499:13
_sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:530:13
init@resource:///org/gnome/shell/ui/extensionSystem.js:48:9
_initializeUI@resource:///org/gnome/shell/ui/main.js:242:5
start@resource:///org/gnome/shell/ui/main.js:138:5
@<main>:1:31

The actor property is no longer needed, as Freon_FreonMenuButton already
is an Actor.

Additionally, we only support old Gnome versions on the Freon versions of the
same era, so we do not need to worry about backwards compatibility (see #153).

Reported-by: @49studebaker
Fixes: #156 ("JS WARNING: " [...])
Related: https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/487 ("this.actor = this removal")
  • Loading branch information
@jonasmalacofilho
jonasmalacofilho committed Dec 15, 2019
commit dbcd29a5a6d82692d237f35b9e906fdd6d0df7a8
2 changes: 1 addition & 1 deletion freon@UshakovVasilii_Github.yahoo.com/extension.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ const FreonMenuButton = GObject.registerClass(class Freon_FreonMenuButton extend
this._createInitialIcon();
}

this.actor.add_actor(this._menuLayout);
this.add_actor(this._menuLayout);

this._settingChangedSignals = [];
this._addSettingChangedSignal('update-time', this._updateTimeChanged.bind(this));
Expand Down