[HL2MP] Fix infinite stack loop on "angle" entity KeyValue#1091
Closed
speedvoltage wants to merge 1 commit into
Closed
[HL2MP] Fix infinite stack loop on "angle" entity KeyValue#1091speedvoltage wants to merge 1 commit into
speedvoltage wants to merge 1 commit into
Conversation
Contributor
|
Duplicate of #380? |
Contributor
|
#380 has been closed by author without merge. @kisak-valve Could you please reopen this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
When attempting to set the angle keyvalue on an entity, there is a risk of encountering an endless stack loop.
Fix:
The update ensures that the angle keyvalue is assigned properly, preventing any unintended recursion. By modifying the method of processing the keyvalue, this fix eliminates the infinite loop and ensures that angles are assigned securely, thus avoiding any stack overflow issues.