angle keyvalue crash fix baseentity_shared.cpp#1143
Open
Nesciuse wants to merge 1 commit into
Open
Conversation
Member
Member
|
Noting that the same happened on #1091. |
Author
|
I am just genuinely wondering how can something this simple and so obviously unable to break anything (as the alternative is straight up infinite recursion crash every time, so not even any backwards compatibility is in the question here) be still not merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
"angle" keyvalue causes a crash because of a mistake in CBaseEntity::KeyValue method which causes infinite recursion