Fix incorrect plane calculation in IntersectRayWithOBB#552
Open
samisalreadytaken wants to merge 2 commits into
Open
Fix incorrect plane calculation in IntersectRayWithOBB#552samisalreadytaken wants to merge 2 commits into
samisalreadytaken wants to merge 2 commits into
Conversation
Bitl
referenced
this pull request
in FIREFIGHT-RELOADED/FIREFIGHT-RELOADED-src-sdk-2013
Mar 10, 2023
Baklojan
added a commit
to Baklojan/source-sdk-2013
that referenced
this pull request
Jun 21, 2024
Bitl
added a commit
to FIREFIGHT-RELOADED/FIREFIGHT-RELOADED-src-sdk-2013
that referenced
this pull request
Feb 20, 2025
…mented. Revert #590.
dimhotepus
added a commit
to Source-Authors/Obsoletium
that referenced
this pull request
Aug 13, 2025
Hull trace against an OBB erroneously transforms calculated normal from world to local space instead of local to world. See ValveSoftware/source-sdk-2013#552 ValveSoftware/source-sdk-2013#590
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hull trace against an OBB erroneously transforms calculated normal from world to local space instead of local to world.
This code is referenced in
SweepBoxToStudio(bone_setup.cpp) >TraceToStudio>CBaseAnimating::TestHitboxes(); however it is not reached in existing SDK code because hull traces are not used.