Fix for swept box rays that were never really working properly with OBBs. (IntersectRayWithOBB)#590
Open
XutaxKamay wants to merge 1 commit into
Open
Conversation
Bitl
added a commit
to FIREFIGHT-RELOADED/FIREFIGHT-RELOADED-src-sdk-2013
that referenced
this pull request
Feb 20, 2025
Contributor
|
This seems like a similar fix to #552 does this do anything different in comparison to that |
Author
It was different at first, but I haven't noticed the commits from June 2024, before the fix it was only for the plane calc and not for the missing transformation So maybe it was pushed later (force pushed after September 2024 even if noticed in June 2024), I don't know |
dimhotepus
added a commit
to Source-Authors/Obsoletium
that referenced
this pull request
Aug 13, 2025
Hull trace against an OBB erroneously transforms calculated normal from world to local space instead of local to world. See ValveSoftware/source-sdk-2013#552 ValveSoftware/source-sdk-2013#590
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IntersectRayWithOBB has a bug where it would somehow ignore angle information inside the matrix.
Why? I don't know. Maybe some developers not wanting to use VectorTransform somehow ? (or overworked)
This is probably present in all Source games (including Source 2) if it hasn't been fixed yet. (?)
This fixes some edge cases where for example a game mod wants to have thicker bullets or other stuff that I'm not aware of (I discovered it by accident by working on the engine).