Extract contextual frames, perform IC with pybasic, and store target + IC frame in LanceDB#47
Conversation
jenna-tomkinson
left a comment
There was a problem hiding this comment.
I am going to leave a comment here as first reviewer since Greg is also assigned to review. I left some clarifying questions where I was a bit lost with what was happening. Feel free to reach out in case you have questions about my questions 😄 Otherwise, I am excited to see what a LanceDB file will look like!
|
Thanks @jenna-tomkinson for the review! There were a couple of comments which I left unresolved which I wanted to get your opinion on so I re-requested your review. Please don't hesitate to let me know if you have any questions / concerns. |
jenna-tomkinson
left a comment
There was a problem hiding this comment.
This PR LGTM! I didn't see anything glaring in the code. This is very exciting work!
|
Thanks @jenna-tomkinson ! Merging this in. |
This PR addresses #43 by extracting contextual frames, perform IC with
pybasic, and store target + IC frame in LanceDB. This work focuses on a limited set of data for development purposes, keeping concurrency in mind throughout to help prepare for #44 . Generally I also tried to be storage space conscious, removing files as they are no longer needed. I removed the earlier array storage work as it felt more appropriate to store image blobs instead (one could always extract the arrays afterwards).To use
pybasicin these changes I forked the repo under WayScience, created a branch from the submodule commit hash referenced in IDR_Stream, and modified thesetup.pyto be installable as a package (the exact reference may be found within thepyproject.tomlfile).I'm attaching an example dataset created from this work here as a reference: example.zip.
Closes #43