Support generating checks for multiple modules - #3962
Conversation
|
@kripken, If you'd like, I can try to split this into separate commits (or PRs) to separate the NFC refactoring and code movement and the functional part. Let me know if you think that's worth it. |
|
Yeah it'd be nice to split this so seeing diff will be easier. |
Decompose the code into more functions and make other simplifying changes to prepare for multi-module support introduced in WebAssembly#3962.
|
The NFC components of this change are in #3964. |
a35ca26 to
b24fadb
Compare
|
Here's the diff from #3964 without whitespace changes: b24fadb?w=1 |
Decompose the code into more functions and make other simplifying changes to prepare for multi-module support introduced in #3962.
In conjunction with the `foreach` tool, allows autogenerating checks for lit tests containing multiple modules. Supporting this will help automatically port existing bespoke wast tests to be lit tests, since many of those tests contain multiple modules per file.
b24fadb to
f86c7d7
Compare
|
Rebased so this can be reviewed normally now. I recommend viewing the diff without whitespace changes. |
aheejin
left a comment
aheejin
left a comment
There was a problem hiding this comment.
Just started looking at this but will be OOO for an hour or two for some errands so only one question..
| ;; RUN: foreach %s %t wasm-opt --extract-function-index=0 -S -o - | filecheck %s | ||
| ;; RUN: foreach %s %t wasm-opt --extract-function-index --pass-arg=extract-function-index@0 -S -o - | filecheck %s | ||
|
|
||
| ;; CHECK: (module |
There was a problem hiding this comment.
Were we already supporting multiple modules within a file in lit tests? I thought that splitting and splicing was supported in our old tests but not here, but I might have missed a few PRs
There was a problem hiding this comment.
Yes, but this is the only test that uses it so far. This test was introduced along with the foreach tool in #3939.
3 participants
In conjunction with the
foreachtool, allows autogenerating checks for littests containing multiple modules. Supporting this will help automatically port
existing bespoke wast tests to be lit tests, since many of those tests contain
multiple modules per file.