Add a script for porting passes tests to lit - #3963
Merged
Merged
Conversation
And use it to port the very simple untee test.
aheejin
reviewed
Jul 2, 2021
| parser.add_argument('--git-add', action='store_true', | ||
| help='Stage changes') | ||
| parser.add_argument('tests', nargs='+', help='The test files to port') | ||
| args = parser.parse_args() |
Member
There was a problem hiding this comment.
It'd be good to add simple --help with a usage string
Member
Author
There was a problem hiding this comment.
This is automatically generated by the arg parser module!
| opts = [('--' + p if not p.startswith('O') and p != 'g' else '-' + p) | ||
| for p in passes] | ||
|
|
||
| run_line = (f';; RUN: foreach %s %t wasm-opt {" ".join(opts)} -S -o -' |
Comment on lines
+80
to
+81
| if args.git_add: | ||
| subprocess.run(['git', 'add', f]) |
Member
Author
There was a problem hiding this comment.
This stages the removal of the file.
aheejin
approved these changes
Jul 2, 2021
Member
Author
|
I fixed the flake8 error and added a new note to be emitted into the ported test identifying it as automatically ported. I realized this actually depends on #3962, so I will wait for that to land before re-generating the test here and landing this. |
kripken
approved these changes
Jul 2, 2021
| @@ -0,0 +1,110 @@ | |||
| #!/usr/bin/env python3 | |||
| subprocess.run(['git', 'add', f]) | ||
|
|
||
| if args.git_add: | ||
| subprocess.run(['git', 'add', dest]) |
Member
There was a problem hiding this comment.
I'm surprised to see the git operations here... I'd expect the user to run them manually. But I don't feel strongly, if this is easier sgtm.
Member
Author
There was a problem hiding this comment.
Yep, it's a little weird to do this in the script, so I put it behind a flag. It's a great quality of life feature, though.
tlively
enabled auto-merge (squash)
July 3, 2021 00:10
tlively
added a commit
to tlively/binaryen
that referenced
this pull request
Jul 3, 2021
Using the script from WebAssembly#3963. Be careful to exclude metrics and fuzz-exec tests, which have output that is not captured by the check generator script.
tlively
added a commit
to tlively/binaryen
that referenced
this pull request
Jul 3, 2021
Using the script from WebAssembly#3963. Be careful to exclude metrics and fuzz-exec tests, which have output that is not captured by the check generator script.
tlively
added a commit
to tlively/binaryen
that referenced
this pull request
Jul 3, 2021
Using the script from WebAssembly#3963. Be careful to exclude metrics and fuzz-exec tests, which have output that is not captured by the check generator script.
tlively
added a commit
to tlively/binaryen
that referenced
this pull request
Jul 3, 2021
Using the script from WebAssembly#3963. Be careful to exclude metrics and fuzz-exec tests, which have output that is not captured by the check generator script.
tlively
added a commit
to tlively/binaryen
that referenced
this pull request
Jul 3, 2021
Using the script from WebAssembly#3963. Be careful to exclude metrics and fuzz-exec tests, which have output that is not captured by the check generator script.
tlively
added a commit
to tlively/binaryen
that referenced
this pull request
Jul 3, 2021
Using the script from WebAssembly#3963. Be careful to exclude metrics and fuzz-exec tests, which have output that is not captured by the check generator script.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And use it to port the very simple untee test.