Skip to content

Properly validate ref.cast when lacking a common supertype #6741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kripken merged 5 commits into from
Jul 23, 2024
Merged

Properly validate ref.cast when lacking a common supertype #6741

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7530b27
fix
kripken Jul 12, 2024
38e1ba9
fix
kripken Jul 12, 2024
6006c19
Merge remote-tracking branch 'origin/main' into ref.cast.val.unreach
kripken Jul 23, 2024
3abe58a
feedback: add test
kripken Jul 23, 2024
459552f
format
kripken Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feedback: add test
  • Loading branch information
@kripken
kripken committed Jul 23, 2024
commit 3abe58a8cc78560850897802a0952bc34015a156
7 changes: 7 additions & 0 deletions src/wasm/wasm-validator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2791,6 +2791,13 @@ void FunctionValidator::visitRefCast(RefCast* curr) {
"ref.cast target type and ref type must have a common supertype")) {
return;
}
// Also error (more generically) on i32 and anything else invalid here.
if (!shouldBeTrue(
curr->type.isRef(),
curr,
"ref.cast must have ref type")) {
return;
}
shouldBeEqual(
curr->type.getHeapType().getBottom(),
curr->ref->type.getHeapType().getBottom(),
Expand Down